Added tests to fully cover graders_controller grader_criteria_mapping function

[mrafie1]

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

• Added unauthorized-access test under student context for the grader_criteria_mapping function in graders_controller_spec.rb
• Added an instructor context test that creates and assigns 3 criteria and 3 TA's, sends GET: grader_criteria_mapping, and asserts that the response is 200 OK, it has the correct media type, the correct filename, and the correct contents inside the CSV.
• Added my name to doc/markus-contributors.txt
• Updated Changelog

Screenshots of your changes (if applicable)

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)	X
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

• I have updated the project Changelog (this is required for all changes).
• I have verified that the pre-commit.ci checks have passed.
• I have verified that the CI tests have passed.
• I have reviewed the test coverage changes reported by Coveralls.
• I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

[coveralls]

Coverage Report for CI Build 25972468581

Coverage increased (+0.01%) to 91.789%

Details

• Coverage increased (+0.01%) from the base build.
• Patch coverage: 20 of 20 lines across 1 file are fully covered (100%).
• No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	48999
Covered Lines:	45721
Line Coverage:	93.31%
Relevant Branches:	1870
Covered Branches:	971
Branch Coverage:	51.93%
Branches in Coverage %:	Yes
Coverage Strength:	129.72 hits per line

---

💛 - Coveralls

[david-yz-liu]

Move this to the "Internal Changes" section, as this section is intended for user-facing changes.

[david-yz-liu]

Rather than hard-code specific names here, you can write ta1 = create(:ta) and then below use ta1.user.user_name. This will help make the test expected values more explicitly connected to the underlying data.

The same is true for specifying criterion names.

Additionally, these don't need to be instance variables (indicated with the @ symbol). Instance variables are used within classes, and in Rails commonly to share data from a controller method in a corresponding view. For tests we can safely just use local variables (without the @).

[david-yz-liu]

This line of code is unnecessary

[mrafie1]

Sorry, forgot to remove 😓

[mrafie1]

Not sure why the MarkUs Tests are failing/being skipped
Let me take a look at it.

[david-yz-liu]

Nice work, @mrafie1