Upgrade to v5.0: fix bugs, add features, improve code quality#136
Open
priscillienMei wants to merge 1 commit intoMatty9191:masterfrom
Open
Upgrade to v5.0: fix bugs, add features, improve code quality#136priscillienMei wants to merge 1 commit intoMatty9191:masterfrom
priscillienMei wants to merge 1 commit intoMatty9191:masterfrom
Conversation
Fix 10 bugs: OLDIFS never saved, quoted wildcard in case default, unquoted OPTIONS string, find word splitting on spaces, missing -v option, unquoted variables, and typos. Refactor certificate info extraction into extract_cert_info() to eliminate duplication. Add connection timeout (-T), JSON output (-j), color output (-C), TLS version selection (-v), and secure PKCS12 password via stdin (-K). Fix issuer/CN parsing to support both LibreSSL and OpenSSL formats. Use system temp directory instead of hardcoded /var/tmp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 10 bugs: OLDIFS never saved, quoted wildcard in case default, unquoted OPTIONS string, find word splitting on spaces, missing -v option, unquoted variables, and typos. Refactor certificate info extraction into extract_cert_info() to eliminate duplication. Add connection timeout (-T), JSON output (-j), color output (-C), TLS version selection (-v), and secure PKCS12 password via stdin (-K). Fix issuer/CN parsing to support both LibreSSL and OpenSSL formats. Use system temp directory instead of hardcoded /var/tmp.