fix: install lefthook hooks via git --git-path hooks#6
Merged
Conversation
Base automatically changed from
fix/entering-the-shell-should-create-dotfile-at-the-root
to
main
May 9, 2026 17:30
The previous worktree guard skipped hook installation entirely from linked worktrees, leaving them to rely on stale symlinks installed earlier from the main checkout — which broke once those store paths were GC'd. Per gitrepository-layout(5), git always looks up hooks in the common gitdir, so a single install from any worktree wires up hooks for every worktree. Resolve the hooks dir with `git rev-parse --git-path hooks` (returns <common-dir>/hooks from any worktree) instead of the literal `.git/hooks`, which fails in worktrees where `.git` is a file.
Mayeu
force-pushed
the
fix/lefthook-install-in-worktrees
branch
from
e82029a to
8c86f5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous worktree guard skipped hook installation entirely from linked worktrees, leaving them to rely on stale symlinks installed earlier from the main checkout — which broke once those store paths were GC'd.
Per gitrepository-layout(5), git always looks up hooks in the common gitdir, so a single install from any worktree wires up hooks for every worktree. Resolve the hooks dir with
git rev-parse --git-path hooks(returns /hooks from any worktree) instead of the literal.git/hooks, which fails in worktrees where.gitis a file.