feat(snap-account-service): add SnapAccountService#8414
Open
feat(snap-account-service): add SnapAccountService#8414
SnapAccountService#8414Conversation
SnapAccountService
david0xd
reviewed
Apr 13, 2026
| @@ -0,0 +1,15 @@ | |||
| # `@metamask/snap-account-service` | |||
|
|
|||
| Service for Account Management Snaps | |||
Contributor
There was a problem hiding this comment.
Can we have little bit more explanation here? For example, what is the main purpose of this service, what we should keep or implement here. So we build up some integrity of this package.
david0xd
reviewed
Apr 13, 2026
| * Initializes the snap account service. | ||
| */ | ||
| async init(): Promise<void> { | ||
| // TODO: Add initialization logic here. |
Contributor
There was a problem hiding this comment.
When is this supposed to be implemented? Looks redundant at this moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
A new service where we will move the common logic of the current monolith
SnapKeyring.The idea is to be able to split this keyring into multiple ones and move the
KeyringEvents logic in this service.High-level architecture is the following:
For now, it's just an empty service, but we will move forward with more follow-up change as we are rewriting the existing
SnapKeyringto use the newKeyringV2.References
N/A
Checklist
Note
Low Risk
Low risk: this mainly introduces a new, currently-empty service package plus build/test/docs wiring, without changing existing runtime logic.
Overview
Introduces a new
@metamask/snap-account-servicepackage with an initialSnapAccountServiceclass (messenger-namespaced, no exposed actions yet) and a basicinit()plus a smoke test.Wires the new package into monorepo metadata and tooling: adds it to the root README package list/dependency graph, TypeScript project references (
tsconfig.json/tsconfig.build.json), CODEOWNERS/teams.json, and updatesyarn.lock.Reviewed by Cursor Bugbot for commit f570e75. Bugbot is set up for automated code reviews on this repo. Configure here.