Skip to content

feat(snap-account-service): add SnapAccountService#8414

Open
ccharly wants to merge 9 commits intomainfrom
cc/feat/snap-account-service
Open

feat(snap-account-service): add SnapAccountService#8414
ccharly wants to merge 9 commits intomainfrom
cc/feat/snap-account-service

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Apr 9, 2026

Explanation

A new service where we will move the common logic of the current monolith SnapKeyring.

The idea is to be able to split this keyring into multiple ones and move the KeyringEvents logic in this service.

High-level architecture is the following:

Screenshot 2026-04-09 at 14 49 23

For now, it's just an empty service, but we will move forward with more follow-up change as we are rewriting the existing SnapKeyring to use the new KeyringV2.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: this mainly introduces a new, currently-empty service package plus build/test/docs wiring, without changing existing runtime logic.

Overview
Introduces a new @metamask/snap-account-service package with an initial SnapAccountService class (messenger-namespaced, no exposed actions yet) and a basic init() plus a smoke test.

Wires the new package into monorepo metadata and tooling: adds it to the root README package list/dependency graph, TypeScript project references (tsconfig.json/tsconfig.build.json), CODEOWNERS/teams.json, and updates yarn.lock.

Reviewed by Cursor Bugbot for commit f570e75. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly changed the title feat(snap-account-service): add SnapAccountService feat(snap-account-service): add SnapAccountService Apr 9, 2026
@ccharly ccharly marked this pull request as ready for review April 9, 2026 15:35
@ccharly ccharly requested a review from a team as a code owner April 9, 2026 15:35
@ccharly ccharly enabled auto-merge April 13, 2026 11:59
@@ -0,0 +1,15 @@
# `@metamask/snap-account-service`

Service for Account Management Snaps
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have little bit more explanation here? For example, what is the main purpose of this service, what we should keep or implement here. So we build up some integrity of this package.

* Initializes the snap account service.
*/
async init(): Promise<void> {
// TODO: Add initialization logic here.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this supposed to be implemented? Looks redundant at this moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants