Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/communication/modbuspoll.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "util/formatdatetime.h"
#include "util/scopelogging.h"


ModbusPoll::ModbusPoll(SettingsModel* pSettingsModel, QObject* parent) : QObject(parent), _bPollActive(false)
{
_pPollTimer = new QTimer(this);
Expand Down Expand Up @@ -107,7 +106,6 @@ void ModbusPoll::onReadDataResult(ResultDoubleList results)
}
}


/*! \brief Returns the AdapterManager owned by this instance. */
AdapterManager* ModbusPoll::adapterManager() const
{
Expand Down
3 changes: 2 additions & 1 deletion src/dialogs/addregisterwidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ AddRegisterWidget::AddRegisterWidget(SettingsModel* pSettingsModel,
}

connect(_pUi->btnAdd, &QPushButton::clicked, this, &AddRegisterWidget::handleResultAccept);
connect(_pAdapterManager, &AdapterManager::buildExpressionResult, this, &AddRegisterWidget::onBuildExpressionResult);
connect(_pAdapterManager, &AdapterManager::buildExpressionResult, this,
&AddRegisterWidget::onBuildExpressionResult);

_axisGroup.setExclusive(true);
_axisGroup.addButton(_pUi->radioPrimary);
Expand Down
18 changes: 18 additions & 0 deletions src/importexport/projectfiledefinitions.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,26 @@ const char cModbusScopeTag[] = "modbusscope";
const char cModbusTag[] = "modbus";
const char cScopeTag[] = "scope";
const char cViewTag[] = "view";
const char cConnectionTag[] = "connection";
const char cDeviceTag[] = "device";
const char cDeviceIdTag[] = "deviceid";
const char cDeviceNameTag[] = "name";
const char cLogTag[] = "log";
const char cConnectionIdTag[] = "connectionid";
const char cConnectionEnabledTag[] = "enabled";
const char cConnectionTypeTag[] = "type";
const char cIpTag[] = "ip";
const char cPortTag[] = "port";
const char cPortNameTag[] = "portname";
const char cBaudrateTag[] = "baudrate";
const char cParityTag[] = "parity";
const char cDataBitsTag[] = "databits";
const char cStopBitsTag[] = "stopbits";
const char cSlaveIdTag[] = "slaveid";
const char cTimeoutTag[] = "timeout";
const char cConsecutiveMaxTag[] = "consecutivemax";
const char cInt32LittleEndianTag[] = "int32littleendian";
const char cPersistentConnectionTag[] = "persistentconnection";
const char cPollTimeTag[] = "polltime";
const char cAbsoluteTimesTag[] = "absolutetimes";
const char cLogToFileTag[] = "logtofile";
Expand Down Expand Up @@ -58,7 +74,9 @@ const char cAdapterSettingsKey[] = "settings";
const char cAdapterIdKey[] = "adapterId";
const char cAdapterKey[] = "adapter";
const char cIdJsonKey[] = "id";
const char cConnectionsJsonKey[] = "connections";
const char cDevicesJsonKey[] = "devices";
const char cConnectionTypeJsonKey[] = "connectiontype";

/* JSON constant values */
const quint32 cMinimumJsonVersion = 6;
Expand Down
19 changes: 17 additions & 2 deletions src/importexport/projectfilehandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include "importexport/projectfiledata.h"
#include "importexport/projectfilejsonexporter.h"
#include "importexport/projectfilejsonparser.h"
#include "importexport/projectfilexmlparser.h"
#include "models/device.h"
#include "models/graphdatamodel.h"
#include "models/guimodel.h"
Expand Down Expand Up @@ -35,8 +36,22 @@ void ProjectFileHandler::openProjectFile(QString projectFilePath)
QTextStream in(&file);
QString projectFileContents = in.readAll();

ProjectFileJsonParser jsonParser;
GeneralError parseErr = jsonParser.parseFile(projectFileContents, &loadedSettings);
GeneralError parseErr;
QString trimmed = projectFileContents.trimmed();
if (trimmed.startsWith('{'))
{
ProjectFileJsonParser jsonParser;
parseErr = jsonParser.parseFile(projectFileContents, &loadedSettings);
}
else if (trimmed.startsWith('<'))
{
ProjectFileXmlParser xmlParser;
parseErr = xmlParser.parseFile(projectFileContents, &loadedSettings);
}
else
{
parseErr.reportError(tr("The file is not a valid MBS project file."));
}

if (parseErr.result())
{
Expand Down
Loading