You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue is that people still have zarr v2 arrays. Ideally, we'd have a way to support both. This solution doesn't appear to be backwards compatible.
Although you'd have to juggle the installed library version, it would be better to have code that checks the current zarr version and then load according to the installed version. Also wrap the loading code with a helpful error if it fails.
Hi,
thank you for your answer. I just tried the fix with zarr version 2 and zarr version 3 and the fix works with both zarr versions.
The fix I propose is actually only to be more explicit in naming the input parameter of zarr.open() instead of relying on positional arguments. (As far as I understand in zarr 3 they are more strict about the input arguments and rely on named arguments)
So In my opinion there is no need to check the current zarr version.
But I am open to learn more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix to make the code for distributed cellpose also zarr v3 compatible.
As it is mentioned in issue #1375