New tracker conditions tables for TOT and HV trips#1826
Conversation
|
Hi @bonventre,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for 98cf831: build (Build queue - API unavailable) |
|
☔ The build tests failed for 98cf831.
N.B. These results were obtained from a build of this Pull Request at 98cf831 after being merged into the base branch at 95f0a83. For more information, please check the job page here. |
rlcee
left a comment
There was a problem hiding this comment.
I know we talked about this before, but I don't recall the conclusion. What will knowing trips do for reco?
If a trip can cross a subrun boundary, it might need the subrun number, since currently event number has to be reset at each subrun
If Panels trip, the row should return a PanelId
we have a guideline of one class definition per include file
I'd be concerned for the per-table overhead, and the two tables can get out of sync - you decided against the one-table designs?
The rest of the implementation looks straightforward
| services.DbService.version : "v1_4" | ||
| # select nominal (perfect) alignment or a misaligned file | ||
| services.DbService.textFile : ["Offline/TrackerConditions/data/MisalignTracker.txt"] | ||
| services.DbService.textFile : ["align.txt"] |
There was a problem hiding this comment.
Ah, maybe intentional in a test fcl..
Adds three new database tables. Two tables implementing the TOT=>drift time calibration, and one table to hold a list of HV trips. Since trips are expected to be within a run/subrun, they are stored as a list of panels + start and end event id