Skip to content

Reopening CaloSurfaceStep extraction with material effects (draft)#1828

Draft
sophiemiddleton wants to merge 35 commits into
Mu2e:mainfrom
sophiemiddleton:materials
Draft

Reopening CaloSurfaceStep extraction with material effects (draft)#1828
sophiemiddleton wants to merge 35 commits into
Mu2e:mainfrom
sophiemiddleton:materials

Conversation

@sophiemiddleton
Copy link
Copy Markdown
Contributor

This pull request introduces calorimeter (Calo) geometry and surfaces into the KinKal geometry framework, enabling extrapolation and material modeling for the calorimeter disks. It adds the necessary data structures, construction logic, and configuration options to integrate the calorimeter with existing geometry and extrapolation tools. The most important changes are grouped below.

Calorimeter geometry integration

  • Added a new Calo class in KinKalGeom to represent the calorimeter disks' geometry and surfaces, including construction from Calorimeter service parameters and accessors for all relevant surfaces (EMC_Disk_0/1_Inner/Outer/Front/Back) (KinKalGeom/inc/Calo.hh, KinKalGeom/src/Calo.cc) [1] [2].
  • Integrated the Calo object into the main geometry (KinKalGeom) as a member, with accessor methods and construction in KinKalGeomMaker (KinKalGeom/inc/KinKalGeom.hh, GeometryService/inc/KinKalGeomMaker.hh, GeometryService/src/KinKalGeomMaker.cc) [1] [2] [3] [4] [5].

Surface enumeration and mapping

  • Extended SurfaceIdEnum and the associated name mapping to include calorimeter disk surfaces and the EMC front panel, ensuring unique identification and lookup for all new surfaces (DataProducts/inc/SurfaceId.hh, DataProducts/src/SurfaceId.cc) [1] [2].
  • Updated the surface mapping in MakeSurfaceSteps_module.cc to handle calorimeter disk surface virtual detectors (CommonMC/src/MakeSurfaceSteps_module.cc) [1] [2].

Configuration and extrapolation support

  • Added calorimeter material and surface options to the FCL configuration files, enabling extrapolation to calorimeter disks and materials in various extrapolation modules (Mu2eKinKal/fcl/prolog.fcl) [1] [2] [3] [4] [5].
  • Added new source files and build rules for the calorimeter geometry and extrapolation logic (KinKalGeom/CMakeLists.txt, Mu2eKinKal/CMakeLists.txt) [1] [2].

Other improvements

  • Ensured explicit usage of KinKal::Disk to avoid ambiguity with other disk definitions (GeometryService/src/KinKalGeomMaker.cc) [1] [2] [3] [4].

These changes collectively provide the infrastructure and configuration needed for calorimeter-aware tracking and extrapolation in the KinKal framework.

@sophiemiddleton sophiemiddleton marked this pull request as draft May 14, 2026 15:35
@FNALbuild
Copy link
Copy Markdown
Collaborator

Hi @sophiemiddleton,
You have proposed changes to files in these packages:

  • TrackerConditions
  • KinKalGeom
  • DataProducts
  • Mu2eKinKal
  • GeometryService
  • CommonMC
  • TrkReco

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for cfb40c2: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at cfb40c2.

Test Result Details
test with Command did not list any other PRs to include
merge Merged cfb40c2 at 95f0a83
build (prof) Log file. Build time: 08 min 29 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO ➡️ TODO (17) FIXME (5) in 19 files
clang-tidy ➡️ 12 errors 287 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at cfb40c2 after being merged into the base branch at 95f0a83.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants