Reopening CaloSurfaceStep extraction with material effects (draft)#1828
Draft
sophiemiddleton wants to merge 35 commits into
Draft
Reopening CaloSurfaceStep extraction with material effects (draft)#1828sophiemiddleton wants to merge 35 commits into
sophiemiddleton wants to merge 35 commits into
Conversation
Collaborator
|
Hi @sophiemiddleton,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for cfb40c2: build (Build queue - API unavailable) |
Collaborator
|
☀️ The build tests passed at cfb40c2.
N.B. These results were obtained from a build of this Pull Request at cfb40c2 after being merged into the base branch at 95f0a83. For more information, please check the job page here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces calorimeter (Calo) geometry and surfaces into the KinKal geometry framework, enabling extrapolation and material modeling for the calorimeter disks. It adds the necessary data structures, construction logic, and configuration options to integrate the calorimeter with existing geometry and extrapolation tools. The most important changes are grouped below.
Calorimeter geometry integration
Caloclass inKinKalGeomto represent the calorimeter disks' geometry and surfaces, including construction from Calorimeter service parameters and accessors for all relevant surfaces (EMC_Disk_0/1_Inner/Outer/Front/Back) (KinKalGeom/inc/Calo.hh,KinKalGeom/src/Calo.cc) [1] [2].Caloobject into the main geometry (KinKalGeom) as a member, with accessor methods and construction inKinKalGeomMaker(KinKalGeom/inc/KinKalGeom.hh,GeometryService/inc/KinKalGeomMaker.hh,GeometryService/src/KinKalGeomMaker.cc) [1] [2] [3] [4] [5].Surface enumeration and mapping
SurfaceIdEnumand the associated name mapping to include calorimeter disk surfaces and the EMC front panel, ensuring unique identification and lookup for all new surfaces (DataProducts/inc/SurfaceId.hh,DataProducts/src/SurfaceId.cc) [1] [2].MakeSurfaceSteps_module.ccto handle calorimeter disk surface virtual detectors (CommonMC/src/MakeSurfaceSteps_module.cc) [1] [2].Configuration and extrapolation support
Mu2eKinKal/fcl/prolog.fcl) [1] [2] [3] [4] [5].KinKalGeom/CMakeLists.txt,Mu2eKinKal/CMakeLists.txt) [1] [2].Other improvements
KinKal::Diskto avoid ambiguity with other disk definitions (GeometryService/src/KinKalGeomMaker.cc) [1] [2] [3] [4].These changes collectively provide the infrastructure and configuration needed for calorimeter-aware tracking and extrapolation in the KinKal framework.