Skip to content

KKMaterial migration#1833

Open
brownd1978 wants to merge 9 commits into
Mu2e:mainfrom
brownd1978:surfgeom
Open

KKMaterial migration#1833
brownd1978 wants to merge 9 commits into
Mu2e:mainfrom
brownd1978:surfgeom

Conversation

@brownd1978
Copy link
Copy Markdown
Collaborator

This PR moves KKMaterial from Mu2eKinKal to GeometryService. Previously, each client created its own instance of KKMaterial, which required duplicate configuration. Now there's one instance, with a single configuration in standard_services. This PR makes no functional change.
There are knockon changes required in Production, EventNtuple and mu2e-trig-config due to configuration and link dependency changes.
This PR is a precursor to creating material objects for KinKal extrapolation.

@brownd1978 brownd1978 requested a review from bonventre May 16, 2026 22:27
@FNALbuild
Copy link
Copy Markdown
Collaborator

Hi @brownd1978,
You have proposed changes to files in these packages:

  • Mu2eG4
  • ProductionTargetGeom
  • fcl
  • GeometryService
  • Mu2eKinKal
  • RecoDataProducts
  • TrackerConditions
  • CalPatRec
  • KinKalGeom

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 94b1baf: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Copy Markdown
Collaborator

☔ The build tests failed for 94b1baf.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 94b1baf at 23fc715
build (prof) Log file. Build time: 04 min 10 sec
ceSimReco Log file. Return Code 90.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file. Return Code 90.
cosmicOffSpill Log file. Return Code 90.
ceSteps Log file.
ceDigi Log file. Return Code 90.
muDauSteps Log file.
ceMix Log file. Return Code 90.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file. Return Code 2.
check_cmake Log file.
FIXME, TODO ➡️ TODO (25) FIXME (9) in 25 files
clang-tidy ➡️ 18 errors 541 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 94b1baf after being merged into the base branch at 23fc715.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@michaelmackenzie
Copy link
Copy Markdown
Contributor

@FNALbuild run build test with Mu2e/mu2e-trig-config#162

@FNALbuild
Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 94b1baf: build (Build queue - API unavailable)

@FNALbuild
Copy link
Copy Markdown
Collaborator

☔ The build tests failed for 94b1baf.

Test Result Details
test with Included Mu2e/mu2e-trig-config#162 @ 6afce9ff8437c0ba98d1d9a2d1c17f3cad00ae28 by merge
merge Merged 94b1baf at 23fc715
build (prof) Log file. Build time: 04 min 10 sec
ceSimReco Log file. Return Code 90.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file. Return Code 90.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO ➡️ TODO (25) FIXME (9) in 25 files
clang-tidy ➡️ 18 errors 541 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 94b1baf after being merged into the base branch at 23fc715.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@brownd1978
Copy link
Copy Markdown
Collaborator Author

Thanks Michael!

@brownd1978
Copy link
Copy Markdown
Collaborator Author

@FNALbuild run build test with Mu2e/mu2e-trig-config#162, Mu2e/Production#541

@FNALbuild
Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 94b1baf: build (Build queue - API unavailable)

@FNALbuild
Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 94b1baf.

Test Result Details
test with Included Mu2e/mu2e-trig-config#162 @ 6afce9ff8437c0ba98d1d9a2d1c17f3cad00ae28 by merge
test with Included Mu2e/Production#541 @ 4689cfbcfa3c98e65bb65957dd294edabc993902 by merge
merge Merged 94b1baf at 23fc715
build (prof) Log file. Build time: 04 min 08 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO ➡️ TODO (25) FIXME (9) in 25 files
clang-tidy ➡️ 18 errors 541 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 94b1baf after being merged into the base branch at 23fc715.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants