Remove unnecessary media permissions to comply with Google Play policy#257
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce platform permission surface area to comply with Google Play policy by removing unnecessary media/photo library permissions and simplifying the app’s runtime permission flow for file downloads.
Changes:
- Removed Android media read permissions (
READ_MEDIA_*) and legacyREAD_EXTERNAL_STORAGEfromAndroidManifest.xml. - Simplified Android storage permission checks in
PermissionsUtil(no runtime permission requests on API 29+). - Removed iOS
NSPhotoLibraryUsageDescriptionfromInfo.plist.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/src/util/permissions_util.dart | Simplifies Android storage permission logic based on SDK level. |
| ios/Runner/Info.plist | Removes photo library usage description entry. |
| android/app/src/main/AndroidManifest.xml | Removes media/external read permissions; keeps legacy write permission with maxSdkVersion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bradly0cjw
reviewed
Feb 7, 2026
| publish_to: 'none' | ||
|
|
||
| # CHECK THE BUILD CODE BEFORE DISTRIBUTION!! | ||
| version: 1.6.9+5269 |
bradly0cjw
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
READ_MEDIA_IMAGES,READ_MEDIA_VIDEO,READ_MEDIA_AUDIO,READ_EXTERNAL_STORAGE, andWRITE_EXTERNAL_STORAGEpermissions from Android manifest — the app only downloads files to app-scoped storage (getExternalStorageDirectory), which requires no permissions on any supported Android version (minSdk 24)READ_MEDIA_*permissions contributed by theopen_filexplugin via manifest merger usingtools:node="remove"PermissionsUtilto always returntrueon Android since no storage permissions are needed for app-scoped storage, removingdevice_info_plusandpermission_handlerimportsNSPhotoLibraryUsageDescriptionfrom iOSInfo.plistsince the app does not access the photo libraryTest plan
READ_MEDIA_*permissions after build