Skip to content

Breaking: [ELI-262] - Configure-CI/CD-pipeline-for-automated-e2e-testing#44

Merged
seansteberisal merged 54 commits intomainfrom
feature/ELI-262-Configure-CI/CD-pipeline-for-automated-e2e-testing
Sep 26, 2025
Merged

Breaking: [ELI-262] - Configure-CI/CD-pipeline-for-automated-e2e-testing#44
seansteberisal merged 54 commits intomainfrom
feature/ELI-262-Configure-CI/CD-pipeline-for-automated-e2e-testing

Conversation

@seansteberisal
Copy link
Copy Markdown
Contributor

@seansteberisal seansteberisal commented Sep 26, 2025

Summary

  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Details

This pull request includes:

  • Integration available for testing in DEV, TEST, PREPROD environments
  • All the tests from the API included
  • Auto Approve and Merge Dependabots
  • Symantic versioning
  • DynamoDB will now teardown and rebuild before tests are run in DEV, TEST
  • PR Title enforcement
  • Automagic adding of JIRA ticket to PR
  • Python package license checking
  • Authentication for AWS services completely reworked to allow for easy authentication when running locally whilst retaining best practice for CI
  • Environment variable resolution is now done by the code, we only need to tell it which environment we want to run in. No need for a .env file anymore
  • Automatic releases with change logs. Description of how to handle versioning is described in the pull request template. Ensure you use the correct PR title before merging any future PRs

Pull Request Naming

Pull requests should be named using the following format:

Tag: [ELI-NNNN] - Short description

Tag can be one of:

  • Fix - for a bug fix. (Patch release)
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems. (Patch release)
  • New - implemented a new feature. (Minor release)
  • Breaking - for a backwards-incompatible enhancement or feature. (Major release)
  • Docs - changes to documentation only. (Patch release)
  • Build - changes to build process only. (No release)
  • Upgrade - for a dependency upgrade. (Patch release)
  • Chore - for refactoring, adding tests, etc. (anything that isn't user-facing). (Patch release)

If the current release is x.y.z then

  • a patch release increases z by 1
  • a minor release increases y by 1
  • a major release increases x by 1

Correct tagging is necessary for our automated versioning and release process (Release).

The description of your pull request will be used as the commit message for the merge, and also be included in the changelog. Please ensure that your title is sufficiently descriptive.

Rerunning Checks

If you need to rename your pull request, you can restart the checks by either:

  • Closing and reopening the pull request
  • pushing an empty commit
    git commit --allow-empty -m 'trigger build'
    git push
  • Amend your last commit and force push to the branch
    git commit --amend --no-edit
    git push --force

Rerunning the checks from within the pull request will not use the updated title.

…pipeline-for-automated-e2e-testing' into feature/ELI-262-Configure-CI/CD-pipeline-for-automated-e2e-testing
…ss in the environment name.

logging level INFO will output to the console by default
environment variables once set in github have been removed
the .env file is no longer needed and will not work
The S3 process no longer uses a prefix, it appears it was not needed.
credential_helper.py file deleted because it is no longer used
commented out continue-on-error: true  not sure if we need this to fail the build because this is not Behave testing
…v or test

Restoration of existing tags will also be included
deletion of test_regression_tests.py and test_smoke_tests.py files
…-automated-e2e-testing

# Conflicts:
#	poetry.lock
@github-actions
Copy link
Copy Markdown
Contributor

This branch is work on a ticket in an NHS England JIRA Project. Here is a handy link to the ticket:
ELI-262

update README.md
remove template .env
removed make run-tests-old command
removed unused CONSTANTS
removed scope="session" from scenarios params fixture
stopped calling delete_all_configs_from_s3() in scenarios params fixture
Copy link
Copy Markdown
Collaborator

@adam-wallernhs1 adam-wallernhs1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed with Sean

@seansteberisal seansteberisal merged commit e1196f6 into main Sep 26, 2025
3 checks passed
@seansteberisal seansteberisal deleted the feature/ELI-262-Configure-CI/CD-pipeline-for-automated-e2e-testing branch September 26, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants