Skip to content

New: [ELI-426] - _plus1day Cohorts#47

Merged
adam-wallernhs1 merged 7 commits intomainfrom
eli-426-new-cohorts
Oct 2, 2025
Merged

New: [ELI-426] - _plus1day Cohorts#47
adam-wallernhs1 merged 7 commits intomainfrom
eli-426-new-cohorts

Conversation

@adam-wallernhs1
Copy link
Copy Markdown
Collaborator

Summary

Remove items from this list if they are not relevant. Remove this line once this has been done

  • ✨ New Feature

Details

  • Added new a new test config, test data and responses, to test ELI-426
  • Updated def _resolve_placeholder_value and def _resolve_age_placeholder to allow the DATE_AGE_65-TOMORROW and DATE_AGE_65-YESTERDAY replacements to aid in boundary testing
  • Updated the vita integration test config to align with the new prod version

Pull Request Naming

Pull requests should be named using the following format:

Tag: [ELI-NNNN] - Short description

Tag can be one of:

  • Fix - for a bug fix. (Patch release)
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems. (Patch release)
  • New - implemented a new feature. (Minor release)
  • Breaking - for a backwards-incompatible enhancement or feature. (Major release)
  • Docs - changes to documentation only. (Patch release)
  • Build - changes to build process only. (No release)
  • Upgrade - for a dependency upgrade. (Patch release)
  • Chore - for refactoring, adding tests, etc. (anything that isn't user-facing). (Patch release)

If the current release is x.y.z then

  • a patch release increases z by 1
  • a minor release increases y by 1
  • a major release increases x by 1

Correct tagging is necessary for our automated versioning and release process (Release).

The description of your pull request will be used as the commit message for the merge, and also be included in the changelog. Please ensure that your title is sufficiently descriptive.

Rerunning Checks

If you need to rename your pull request, you can restart the checks by either:

  • Closing and reopening the pull request
  • pushing an empty commit
    git commit --allow-empty -m 'trigger build'
    git push
  • Amend your last commit and force push to the branch
    git commit --amend --no-edit
    git push --force

Rerunning the checks from within the pull request will not use the updated title.

…age tomorrow or yesterday

- added TCs for ELI-426
- made a minor chnage to the vita integration test config to ensure virtual N was orking as expected
…age tomorrow or yesterday

- added TCs for ELI-426
- made a minor change to the vita integration test config to ensure virtual N was working as expected
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 1, 2025

This branch is work on a ticket in an NHS England JIRA Project. Here is a handy link to the ticket:
ELI-426

@adam-wallernhs1 adam-wallernhs1 marked this pull request as ready for review October 1, 2025 09:04
Comment thread utils/placeholder_utils.py
seansteberisal
seansteberisal previously approved these changes Oct 1, 2025
@adam-wallernhs1 adam-wallernhs1 merged commit 07df3ef into main Oct 2, 2025
3 checks passed
@adam-wallernhs1 adam-wallernhs1 deleted the eli-426-new-cohorts branch October 2, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants