Skip to content

eli-216 adding APIM target headers to allow us to receive NHS Login NHS number#30

Merged
eddalmond1 merged 1 commit intomainfrom
feature/eli-216-adding-APIM-target-headers
Jun 20, 2025
Merged

eli-216 adding APIM target headers to allow us to receive NHS Login NHS number#30
eddalmond1 merged 1 commit intomainfrom
feature/eli-216-adding-APIM-target-headers

Conversation

@eddalmond1
Copy link
Copy Markdown
Collaborator

Description

Adding target headers to trigger the APIM proxy to include the NHS Login NHS Number in the request to us.

Context

We want to a) log, for audit purposes, the identity of requestors and b) potentially cross-check the NHS number in the path vs. the NHS Login user NHS Number for authorisation purposes.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jhadfield-NHS jhadfield-NHS self-requested a review June 20, 2025 12:47
Copy link
Copy Markdown
Contributor

@jhadfield-NHS jhadfield-NHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddalmond1 eddalmond1 merged commit 7764124 into main Jun 20, 2025
37 checks passed
@eddalmond1 eddalmond1 deleted the feature/eli-216-adding-APIM-target-headers branch June 20, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants