Skip to content

bugfix - ensuring prism pattern matching #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddalmond1 merged 4 commits into from
Jan 15, 2026
Merged

bugfix - ensuring prism pattern matching #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3b8283
bugfix - ensuring prism pattern matching
eddalmond1 Jan 15, 2026
7ef7969
adding vale
eddalmond1 Jan 15, 2026
195dc27
appeasing vale
eddalmond1 Jan 15, 2026
e0e0d99
appeasing vale
eddalmond1 Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sandbox/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ This will stop the sandbox environment.
There are a number of examples of responses which can be returned by passing specific NHS Numbers in the patient query parameter:

```bash
curl -X GET "http://0.0.0.0:9000/patient-check/<NHS_NUMBER>
curl -X GET "http://0.0.0.0:9000/patient-check/50000000101" -H "apikey:1"
```

or for sandbox:
Expand Down
3 changes: 2 additions & 1 deletion sandbox/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ def get_prism_prompt_for_example(patient_examples: dict, request: Request) -> st
Given the whole request, return the `Prefer:` header value if a specific
example is desired. Otherwise, return `None`.
"""
for patient_id, example in patient_examples.items():
sorted_examples = sorted(patient_examples.items(), key=lambda x: len(x[0]), reverse=True)
for patient_id, example in sorted_examples:
if patient_id in request.full_path:
return example
return None
Expand Down
2 changes: 2 additions & 0 deletions scripts/config/vale/styles/config/vocabularies/words/accept.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Dependabot
Gitleaks
Grype
idempotence
lxml
Makefile
npm
OAuth
Octokit
Expand Down
2 changes: 1 addition & 1 deletion specification/proxygen-cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ to deploy our OAS specification to different environments, deploy a sandbox back

### Install Proxygen-CLI

The `proxygen-cli` package currently requires Python v3.9 or greater, but not v3.13.
The `proxygen-cli` package currently requires Python v3.9 or greater. Note: While `proxygen-cli` v2.x technically supports Python 3.13, its dependency constraints still require lxml <5.0, which is incompatible with Python 3.13. For Python 3.13 users, install `proxygen-cli` in a separate virtual environment using Python 3.11 or 3.12 until this is resolved upstream.

```bash
pyenv install 3.11.1
Expand Down
Loading