Skip to content

+generate DynamoDB data generate_dynamo_data.py#188

Merged
adam-wallernhs1 merged 3 commits intomainfrom
test/ivma-dynamodb-data-uploader
Jun 24, 2025
Merged

+generate DynamoDB data generate_dynamo_data.py#188
adam-wallernhs1 merged 3 commits intomainfrom
test/ivma-dynamodb-data-uploader

Conversation

@ivma1-nhs
Copy link
Copy Markdown
Contributor

Description

Refactored and modularised the JSON test data generator to align with SOLID principles. Introduced class-based structure for date variable resolution and JSON placeholder substitution. Centralised date formatting logic and added structured logging for traceability.

Context

The previous script lacked structure and reusability, and hardcoded the date format in multiple places. This change provides a cleaner, testable, and maintainable utility for resolving dynamic date placeholders like <<DATE_AGE_75>> or <<DATE_DAY_-7>> within test data files. The output format is now standardised and easier to audit.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ivma1-nhs ivma1-nhs self-assigned this Jun 24, 2025
@ivma1-nhs ivma1-nhs added the enhancement New feature or request label Jun 24, 2025
@adam-wallernhs1 adam-wallernhs1 merged commit 46255ca into main Jun 24, 2025
22 checks passed
@ivma1-nhs ivma1-nhs deleted the test/ivma-dynamodb-data-uploader branch June 24, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants