+generate DynamoDB data generate_dynamo_data.py#188
Merged
adam-wallernhs1 merged 3 commits intomainfrom Jun 24, 2025
Merged
Conversation
adam-wallernhs1
previously approved these changes
Jun 24, 2025
adam-wallernhs1
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored and modularised the JSON test data generator to align with SOLID principles. Introduced class-based structure for date variable resolution and JSON placeholder substitution. Centralised date formatting logic and added structured logging for traceability.
Context
The previous script lacked structure and reusability, and hardcoded the date format in multiple places. This change provides a cleaner, testable, and maintainable utility for resolving dynamic date placeholders like
<<DATE_AGE_75>>or<<DATE_DAY_-7>>within test data files. The output format is now standardised and easier to audit.Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.