Skip to content

fix : iam policy kms key #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Karthikeyannhs wants to merge 1 commit into from
Closed

fix : iam policy kms key #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 2 additions & 28 deletions infrastructure/modules/kinesis_firehose/kms.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ resource "aws_kms_key_policy" "firehose_key_policy" {
policy = data.aws_iam_policy_document.firehose_kms_key_policy.json
}


data "aws_iam_policy_document" "firehose_kms_key_policy" {
#checkov:skip=CKV_AWS_111: Root user needs full KMS key management
#checkov:skip=CKV_AWS_356: Root user needs full KMS key management
#checkov:skip=CKV_AWS_109: Root user needs full KMS key management

statement {
sid = "EnableIamUserPermissions"
effect = "Allow"
Expand All @@ -32,22 +32,9 @@ data "aws_iam_policy_document" "firehose_kms_key_policy" {
actions = ["kms:*"]
resources = ["*"]
}
statement {
sid = "EnableRootUserPermissions"
effect = "Allow"

principals {
type = "AWS"
identifiers = ["arn:aws:iam::${data.aws_caller_identity.current.account_id}:root"]
}

actions = ["kms:*"]
resources = ["*"]
}

# Your existing statements below...
statement {
sid = "AllowFirehoseAccess"
sid = "Allow Firehose Service Access"
effect = "Allow"
principals {
type = "Service"
Expand All @@ -62,17 +49,6 @@ data "aws_iam_policy_document" "firehose_kms_key_policy" {
resources = [aws_kms_key.firehose_cmk.arn]
}

statement {
sid = "AllowFirehoseRoleUsage"
effect = "Allow"
principals {
type = "AWS"
identifiers = [var.audit_firehose_role_arn]
}
actions = ["kms:*"]
resources = [aws_kms_key.firehose_cmk.arn]
}

statement {
sid = "AllowCloudWatchLogsUseOfTheKey"
effect = "Allow"
Expand All @@ -90,5 +66,3 @@ data "aws_iam_policy_document" "firehose_kms_key_policy" {
resources = [aws_kms_key.firehose_cmk.arn]
}
}