Skip to content

Fix/kinesisfirehose logging permissions#203

Merged
Karthikeyannhs merged 5 commits intomainfrom
fix/kinesisfirehose_logging_permissions
Jul 1, 2025
Merged

Fix/kinesisfirehose logging permissions#203
Karthikeyannhs merged 5 commits intomainfrom
fix/kinesisfirehose_logging_permissions

Conversation

@Karthikeyannhs
Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

TOEL2
TOEL2 previously approved these changes Jul 1, 2025
Copy link
Copy Markdown
Contributor

@TOEL2 TOEL2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Copy Markdown
Contributor

@ayeshalshukri1-nhs ayeshalshukri1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Karthikeyannhs Karthikeyannhs merged commit 45a3a66 into main Jul 1, 2025
24 checks passed
@Karthikeyannhs Karthikeyannhs deleted the fix/kinesisfirehose_logging_permissions branch July 1, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants