Skip to content

github role permissions#217

Merged
Karthikeyannhs merged 1 commit intomainfrom
github_role_permissions
Jul 7, 2025
Merged

github role permissions#217
Karthikeyannhs merged 1 commit intomainfrom
github_role_permissions

Conversation

@Karthikeyannhs
Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Karthikeyannhs Karthikeyannhs force-pushed the github_role_permissions branch from c10f7bf to 3abcfef Compare July 4, 2025 14:58
@Karthikeyannhs Karthikeyannhs marked this pull request as ready for review July 4, 2025 15:28
@Karthikeyannhs Karthikeyannhs marked this pull request as draft July 7, 2025 09:09
@Karthikeyannhs Karthikeyannhs marked this pull request as ready for review July 7, 2025 09:09
@Karthikeyannhs Karthikeyannhs reopened this Jul 7, 2025
@Karthikeyannhs Karthikeyannhs merged commit ad76156 into main Jul 7, 2025
27 checks passed
shweta-nhs pushed a commit that referenced this pull request Jul 7, 2025
robbailiff2 pushed a commit that referenced this pull request Jul 7, 2025
* Patch - Initial test and AuditService stub.

* Patch - Commit 1 Adds flask g and before and after request audit

* Patch - Added audit record logic.

* Patch - Fix broken tests.

* Adding integration test for audit

* Fixed actions part of the audit

* Added unit tests for AuditContext

* Added unit tests and fixed TODOs

* Fixed TODOs

* Fixed linting

* Uses list[SuggestedAction] instead of SuggestedActions

* Adds internal action code to audit actions

* Fix todo's

* Fix linting again

* Fixing priority type

* Cleaning audit bucket after use per every test run

* Fix lint

* Fix format and lint

* Convert audit_log into camelCase when writing record to firehose

* github role permissions - reduced (#217)

* Adds audit package for separation of concerns

---------

Co-authored-by: Shweta <216860557+shweta-nhs@users.noreply.github.com>
Co-authored-by: Karthikeyannhs <174426205+Karthikeyannhs@users.noreply.github.com>
@Karthikeyannhs Karthikeyannhs deleted the github_role_permissions branch July 21, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants