Skip to content

Feature/eja eli 343 adding deletion protection and ig public access block#249

Merged
eddalmond1 merged 2 commits intomainfrom
feature/eja-eli-343-adding-deletion-protection-and-IG-public-access-block
Jul 22, 2025
Merged

Feature/eja eli 343 adding deletion protection and ig public access block#249
eddalmond1 merged 2 commits intomainfrom
feature/eja-eli-343-adding-deletion-protection-and-IG-public-access-block

Conversation

@eddalmond1
Copy link
Copy Markdown
Collaborator

Description

Adding Terraform changes to address two of the issues highlighted in AWS SecurityHub - see https://nhsd-confluence.digital.nhs.uk/spaces/Vacc/pages/1132925310/Security+Audit+-+Preprod+-+Preparation+for+Pen+Test for all issues highlighted.

Specifically, this PR:

  1. Restricts VPCs from using Internet Gateways to access the public internet. There is a risk that this might 'break' our API Gateway - I've found conflicting advice in the AWS documentation, so the only way to know for sure is to deploy this change and check everything works as intended.
  2. Adds deletion protection, in Production only, to the dynamoDB table we create.

Context

It addresses two Medium severity security issues.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

…ing access to public internet via Internet Gateway, and adding table protection in Prod for DynamoDB
…dding-deletion-protection-and-IG-public-access-block
@eddalmond1 eddalmond1 merged commit 50cf200 into main Jul 22, 2025
22 checks passed
@eddalmond1 eddalmond1 deleted the feature/eja-eli-343-adding-deletion-protection-and-IG-public-access-block branch July 22, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants