Skip to content

ELI-351: Moves/deletes tests after refactoring #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shweta-nhs merged 7 commits into from
Aug 1, 2025
Merged

ELI-351: Moves/deletes tests after refactoring #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d41d66
ELI-351: Moves/deletes tests after refactoring
shweta-nhs Jul 31, 2025
3cb1481
ELI-351: Extracts EligibilityResultBuilder and adds tests
shweta-nhs Jul 31, 2025
dc9de8e
ELI-351: De-extracts EligibilityResultBuilder and moves tests to Elig…
shweta-nhs Jul 31, 2025
8886ff5
ELI-351: Removes duplicated tests
shweta-nhs Jul 31, 2025
e3dd187
ELI-351: Removes duplicated tests #2
shweta-nhs Jul 31, 2025
9adf850
ELI-351: Adds validation and audit layer to Readme
shweta-nhs Aug 1, 2025
de48adb
Merge branch 'main' into refactor/ELI-351
shweta-nhs Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,25 @@ graph TB
direction TB
App["app.py (WireUp DI)"]
Config["config.py, error_handler.py"]
subgraph "Audit Layer"
direction TB
Audit["audit/audit_service.py"]
AuditModels["audit/audit_models.py"]
end
subgraph "Validation Layer"
direction TB
Validator["common/request_validator.py"]
ApiErrResp["common/api_error_response.py"]
end
subgraph "Presentation Layer"
direction TB
View["views/eligibility.py"]
ResponseModel["views/response_model/eligibility.py"]
ResponseModel["views/response_model/eligibility_response.py"]
end
subgraph "Business Logic Layer"
direction TB
Service["services/eligibility_services.py"]
Operators["services/rules/operators.py"]
Operators["services/operators/operators.py"]
end
subgraph "Data Access Layer"
direction TB
Expand All @@ -207,24 +217,30 @@ graph TB
end
subgraph "Models"
direction TB
ModelElig["model/eligibility.py"]
ModelRules["model/rules.py"]
ModelElig["model/eligibility_status.py"]
ModelRules["model/campaign_config.py"]
end
end

Lambda -->|"loads"| App
App -->|injects| View
View -->|calls| Service
View -->|validates via| Validator
View -->|audits via| Audit
View -->|uses| RespModel
Audit -->|uses| AuditModels
Validator -->|uses| ApiErrResp

Service -->|calls| Operators
Service -->|calls| PersonRepo
Service -->|calls| CampaignRepo
PersonRepo -->|uses| DynamoDB
CampaignRepo -->|uses| S3Bucket
View -->|uses| ResponseModel
App -->|reads| Config
App -->|wires| Factory

Service -->|uses| ModelElig
Operators -->|uses| ModelRules
App -->|wires| Factory

```

Expand Down
Loading