Skip to content

Bug/te eli 373 cohortlabel#280

Merged
TOEL2 merged 6 commits intomainfrom
bug/te-ELI-373-cohortlabel
Aug 8, 2025
Merged

Bug/te eli 373 cohortlabel#280
TOEL2 merged 6 commits intomainfrom
bug/te-ELI-373-cohortlabel

Conversation

@TOEL2
Copy link
Copy Markdown
Contributor

@TOEL2 TOEL2 commented Aug 7, 2025

Following the discovery of the ELI-373 bug it became apparent that we were previously filtering out parts of AND rules before we loop through each individual rule. This causes orphaned general rules which were previously part of AND rules to be evaluated on their own.

To solve this I have moved the filtering of rules to be inside the loop, so that we can understand the full context of the rule group (i.e does the group contain any non matching cohort labels).

It's a slight refactor that may deprecate the get_exclusion_rules function in favour of a new one I added, although I have kept that function in case we want to use it for another purpose for now until review.

Type of changes

  • [X ] Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • [ X] Bug fix (non-breaking change which fixes an issue)

Checklist

  • [ X] I am familiar with the contributing guidelines
  • [ X] I have followed the code style of the project
  • [ X] I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • [ X] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@TOEL2 TOEL2 marked this pull request as ready for review August 7, 2025 15:46
@TOEL2 TOEL2 closed this Aug 7, 2025
@TOEL2 TOEL2 reopened this Aug 7, 2025
@TOEL2 TOEL2 merged commit e1d20a9 into main Aug 8, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants