clean up the dormant PII logs

[Karthikeyannhs]

Description

Context

Type of changes

• Refactoring (non-breaking change)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would change existing functionality)
• Bug fix (non-breaking change which fixes an issue)

Checklist

• I am familiar with the contributing guidelines
• I have followed the code style of the project
• I have added tests to cover my changes
• I have updated the documentation accordingly
• This PR is a result of pair or mob programming

---

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

• I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

[ayeshalshukri1-nhs]

I also found a few other logger instances. Do these produce potential PII ??

eligibility-signposting-api/src/eligibility_signposting_api/repos/person_repo.py

Line 23 in 8a677c9

logger.info("person_table %r", table, extra={"table": table})

eligibility-signposting-api/src/eligibility_signposting_api/common/error_handler.py

Line 14 in 8a677c9

logger.exception("Unexpected Exception", exc_info=e)

[Karthikeyannhs]

I also found a few other logger instances. Do these produce potential PII ??

eligibility-signposting-api/src/eligibility_signposting_api/repos/person_repo.py

Line 23 in 8a677c9

logger.info("person_table %r", table, extra={"table": table})

eligibility-signposting-api/src/eligibility_signposting_api/common/error_handler.py

Line 14 in 8a677c9

logger.exception("Unexpected Exception", exc_info=e)

No , First one just logs the table name
second one just logs the stacktrace.

[ayeshalshukri1-nhs]

LGTM !! Answered comments, approved.