Skip to content

Updated external write role with policies for audit copy #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TOEL2 merged 3 commits into from
Sep 17, 2025
Merged

Updated external write role with policies for audit copy #314

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e1fcb
Updated external write role with policies for audit copy
robbailiff2 Aug 28, 2025
73ea8f1
Removed s3 delete permissions
robbailiff2 Aug 28, 2025
1d3d145
Merge branch 'main' into feature/rgjb-te-eli-422-s3_audit_copy_terraf…
TOEL2 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions infrastructure/stacks/api-layer/iam_policies.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ data "aws_iam_policy_document" "s3_audit_kms_key_policy" {
#checkov:skip=CKV_AWS_356: Root user needs full KMS key management
#checkov:skip=CKV_AWS_109: Root user needs full KMS key management

# Allow root user to have full control
statement {
sid = "EnableIamUserPermissions"
effect = "Allow"
Expand All @@ -351,12 +352,20 @@ data "aws_iam_policy_document" "s3_audit_kms_key_policy" {
actions = ["kms:*"]
resources = ["*"]
}

# Allow Lambda, Firehose, and external write roles to use the KMS key
statement {
sid = "AllowLambdaFullWrite"
sid = "AllowAuditKeyAccess"
effect = "Allow"
principals {
type = "AWS"
identifiers = [aws_iam_role.eligibility_lambda_role.arn, aws_iam_role.eligibility_audit_firehose_role.arn]
identifiers = concat(
[
aws_iam_role.eligibility_lambda_role.arn,
aws_iam_role.eligibility_audit_firehose_role.arn
],
aws_iam_role.write_access_role[*].arn
)
}
actions = [
"kms:Decrypt",
Expand Down Expand Up @@ -459,3 +468,39 @@ resource "aws_kms_key_policy" "sns_encryption_key_policy" {
]
})
}

# Policy doc for external write role to read, move, and tag objects in S3
data "aws_iam_policy_document" "external_s3_read_move_policy_doc" {
statement {
sid = "ListBucket"
actions = [
"s3:ListBucket",
"s3:ListBucketVersions"
]
resources = [
module.s3_audit_bucket.storage_bucket_arn
]
}

statement {
sid = "ReadMoveTagObjects"
actions = [
"s3:GetObject",
"s3:GetObjectVersion",
"s3:GetObjectTagging",
"s3:PutObjectTagging",
"s3:PutObject"
]
resources = [
"${module.s3_audit_bucket.storage_bucket_arn}/*"
]
}
}

# Attach external S3 read, move & tagging policy to external write role
resource "aws_iam_role_policy" "external_s3_read_move_policy" {
count = length(aws_iam_role.write_access_role)
name = "S3ReadMoveTagAccess"
role = aws_iam_role.write_access_role[count.index].id
policy = data.aws_iam_policy_document.external_s3_read_move_policy_doc.json
}