Skip to content

ELI-597: Automates NHS Number salt creation and rotation#537

Merged
shweta-nhs merged 12 commits intomainfrom
ELI-597
Jan 12, 2026
Merged

ELI-597: Automates NHS Number salt creation and rotation#537
shweta-nhs merged 12 commits intomainfrom
ELI-597

Conversation

@shweta-nhs
Copy link
Copy Markdown
Contributor

@shweta-nhs shweta-nhs commented Jan 8, 2026

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Copy Markdown
Collaborator

@eddalmond1 eddalmond1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - a few minor checks around ensuring tags are definitely being managed by this process completely

Comment thread infrastructure/stacks/api-layer/iam_policies.tf Outdated
Comment thread infrastructure/stacks/api-layer/scripts/create_pending_secret.py
Comment thread infrastructure/stacks/api-layer/scripts/promote_to_current.py
Comment thread infrastructure/stacks/api-layer/step_functions.tf
Comment thread infrastructure/stacks/api-layer/scripts/create_pending_secret.py Outdated
Comment thread infrastructure/stacks/api-layer/step_functions.tf
Comment thread infrastructure/stacks/api-layer/lambda.tf Fixed
Comment thread infrastructure/stacks/api-layer/lambda.tf
Comment thread infrastructure/stacks/api-layer/lambda.tf
Comment thread infrastructure/stacks/api-layer/lambda.tf
Comment thread infrastructure/stacks/api-layer/lambda.tf Fixed
Comment thread infrastructure/stacks/api-layer/lambda.tf
Comment thread infrastructure/stacks/api-layer/lambda.tf Fixed
Comment thread infrastructure/stacks/api-layer/lambda.tf
Comment thread infrastructure/stacks/api-layer/sns.tf Fixed
Comment thread infrastructure/stacks/api-layer/step_functions.tf
Comment thread infrastructure/stacks/api-layer/lambda.tf Fixed
Comment thread infrastructure/stacks/api-layer/lambda.tf Fixed
Comment thread infrastructure/stacks/api-layer/lambda.tf
Comment thread infrastructure/stacks/api-layer/lambda.tf
Comment thread infrastructure/stacks/api-layer/lambda.tf
Comment thread infrastructure/stacks/api-layer/lambda.tf Fixed
Comment thread infrastructure/stacks/api-layer/lambda.tf Fixed
Comment thread infrastructure/stacks/api-layer/sns.tf Fixed
Comment thread infrastructure/stacks/api-layer/step_functions.tf
Comment thread infrastructure/stacks/api-layer/step_functions.tf
eddalmond1
eddalmond1 previously approved these changes Jan 12, 2026
@shweta-nhs shweta-nhs merged commit 524b2e9 into main Jan 12, 2026
25 checks passed
@shweta-nhs shweta-nhs deleted the ELI-597 branch January 12, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants