Skip to content

Updated ssm param terraform and tf vars in github workflows #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robbailiff2 merged 3 commits into from
Feb 2, 2026
Merged

Updated ssm param terraform and tf vars in github workflows #565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f22baad
Updated ssm param terraform and tf vars in github workflows
robbailiff2 Feb 2, 2026
0c8aa92
Updated vars and workflows
robbailiff2 Feb 2, 2026
0615563
Merge branch 'main' into feayure/rgjb-eli-604-update-ssm-terraform
Karthikeyannhs Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/base-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ jobs:
TF_VAR_SPLUNK_HEC_TOKEN: ${{ secrets.SPLUNK_HEC_TOKEN }}
TF_VAR_SPLUNK_HEC_ENDPOINT: ${{ secrets.SPLUNK_HEC_ENDPOINT }}
TF_VAR_OPERATOR_EMAILS: ${{ vars.SECRET_ROTATION_OPERATOR_EMAILS }}
TF_VAR_PROXYGEN_PRIVATE_KEY: ${{ (needs.metadata.outputs.environment == 'preprod' || needs.metadata.outputs.environment == 'prod') && secrets.PROXYGEN_PRIVATE_KEY || '' }}


working-directory: ./infrastructure
shell: bash
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/cicd-2-publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ jobs:
TF_VAR_SPLUNK_HEC_TOKEN: ${{ secrets.SPLUNK_HEC_TOKEN }}
TF_VAR_SPLUNK_HEC_ENDPOINT: ${{ secrets.SPLUNK_HEC_ENDPOINT }}
TF_VAR_OPERATOR_EMAILS: ${{ vars.SECRET_ROTATION_OPERATOR_EMAILS }}
TF_VAR_PROXYGEN_PRIVATE_KEY: ""

run: |
mkdir -p ./build
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/cicd-3-test-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ jobs:
TF_VAR_SPLUNK_HEC_TOKEN: ${{ secrets.SPLUNK_HEC_TOKEN }}
TF_VAR_SPLUNK_HEC_ENDPOINT: ${{ secrets.SPLUNK_HEC_ENDPOINT }}
TF_VAR_OPERATOR_EMAILS: ${{ vars.SECRET_ROTATION_OPERATOR_EMAILS }}
TF_VAR_PROXYGEN_PRIVATE_KEY: ""

run: |
mkdir -p ./build
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ jobs:
TF_VAR_SPLUNK_HEC_TOKEN: ${{ secrets.SPLUNK_HEC_TOKEN }}
TF_VAR_SPLUNK_HEC_ENDPOINT: ${{ secrets.SPLUNK_HEC_ENDPOINT }}
TF_VAR_OPERATOR_EMAILS: ${{ vars.SECRET_ROTATION_OPERATOR_EMAILS }}
TF_VAR_PROXYGEN_PRIVATE_KEY: ${{ (needs.metadata.outputs.environment == 'preprod' || needs.metadata.outputs.environment == 'prod') && secrets.PROXYGEN_PRIVATE_KEY || '' }}
run: |
mkdir -p ./build
echo "🚀 Deploying ${{ needs.validate.outputs.dev_tag }} to TEST"
Expand Down
1 change: 1 addition & 0 deletions infrastructure/stacks/networking/ssm.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
resource "aws_ssm_parameter" "proxygen_private_key" {
count = var.environment == "prod" || var.environment == "preprod" ? 1 : 0
Copy link
Copy Markdown
Collaborator

@eddalmond1 eddalmond1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be dev only, and we should store both the 'prod' and 'ptl' keys as separate params. I suggest keeping this key's name for the prod one, and add a ptl key

Copy link
Copy Markdown
Collaborator

@eddalmond1 eddalmond1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would then need to amend above workflows

Copy link
Copy Markdown
Contributor Author

@robbailiff2 robbailiff2 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has now been updated

name = "/${var.environment}/proxygen/private_key"
type = "SecureString"
key_id = aws_kms_key.networking_ssm_key.id
Expand Down
Loading