Skip to content

Feature/eli 686 adding performance endpoint #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TOEL2 wants to merge 2 commits into from
Closed

Feature/eli 686 adding performance endpoint #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3acb30d
[ELI-686] - Adding new lambda route
TOEL2 Mar 4, 2026
c67513f
[ELI-686] - Adding new api gateway route
TOEL2 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion infrastructure/stacks/api-layer/api_gateway.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,24 @@ resource "aws_api_gateway_resource" "patient_check" {
path_part = "patient-check"
}

resource "aws_api_gateway_resource" "patient_check_perf" {
rest_api_id = module.eligibility_signposting_api_gateway.rest_api_id
parent_id = aws_api_gateway_resource.patient_check.id
path_part = "_perf"
}

resource "aws_api_gateway_resource" "patient" {
rest_api_id = module.eligibility_signposting_api_gateway.rest_api_id
parent_id = aws_api_gateway_resource.patient_check.id
path_part = "{id}"
}

resource "aws_api_gateway_resource" "patient_perf" {
rest_api_id = module.eligibility_signposting_api_gateway.rest_api_id
parent_id = aws_api_gateway_resource.patient_check_perf.id
path_part = "{id}"
}

resource "aws_api_gateway_resource" "patient_check_status" {
rest_api_id = module.eligibility_signposting_api_gateway.rest_api_id
parent_id = aws_api_gateway_resource.patient_check.id
Expand All @@ -34,7 +46,8 @@ resource "aws_api_gateway_deployment" "eligibility_signposting_api" {
triggers = {
redeployment = sha1(jsonencode([
aws_api_gateway_integration.get_patient_check.id,
aws_api_gateway_integration.get_patient_check_status.id
aws_api_gateway_integration.get_patient_check_status.id,
aws_api_gateway_integration.get_patient_check_perf.id
]))
}

Expand Down
34 changes: 34 additions & 0 deletions infrastructure/stacks/api-layer/patient_check.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,40 @@
]
}

resource "aws_api_gateway_method" "get_patient_check_perf" {
#checkov:skip=CKV_AWS_59: API is secured via Apigee proxy with mTLS, API keys are not used
rest_api_id = module.eligibility_signposting_api_gateway.rest_api_id
resource_id = aws_api_gateway_resource.patient_perf.id
http_method = "GET"
authorization = "NONE"
api_key_required = false

request_validator_id = aws_api_gateway_request_validator.patient_check_validator.id

request_parameters = {
"method.request.path.id" = true
}

depends_on = [
aws_api_gateway_resource.patient_check_perf,
aws_api_gateway_resource.patient_perf,
aws_api_gateway_resource.patient_check,
]
}
Comment on lines +41 to +60

Check warning

Code scanning / checkov

Ensure there is no open access to back-end resources through API Warning

Ensure there is no open access to back-end resources through API

resource "aws_api_gateway_integration" "get_patient_check_perf" {
rest_api_id = module.eligibility_signposting_api_gateway.rest_api_id
resource_id = aws_api_gateway_resource.patient_perf.id
http_method = aws_api_gateway_method.get_patient_check_perf.http_method
integration_http_method = "POST"
type = "AWS_PROXY"
uri = module.eligibility_signposting_lambda_function.aws_lambda_invoke_arn

depends_on = [
aws_api_gateway_method.get_patient_check_perf
]
}

resource "aws_api_gateway_method" "get_patient_check_status" {
#checkov:skip=CKV_AWS_59: API is secured via Apigee proxy with mTLS, API keys are not used
#checkov:skip=CKV2_AWS_53: No request parameters to validate for static healthcheck endpoint
Expand Down
6 changes: 6 additions & 0 deletions src/eligibility_signposting_api/views/eligibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from typing import Any

from flask import Blueprint, make_response, request
from aws_xray_sdk.core import xray_recorder
from flask.typing import ResponseReturnValue
from wireup import Injected

Expand Down Expand Up @@ -45,10 +46,15 @@ def api_status() -> ResponseReturnValue:

@eligibility_blueprint.get("/", defaults={"nhs_number": ""})
@eligibility_blueprint.get("/<nhs_number>")
@eligibility_blueprint.get("/_perf/<nhs_number>")
@validate_request_params()
def check_eligibility(
nhs_number: NHSNumber, eligibility_service: Injected[EligibilityService], audit_service: Injected[AuditService]
) -> ResponseReturnValue:

if request.path.startswith(f"/{URL_PREFIX}/_perf"):
xray_recorder.put_annotation("perf_test", True)

logger.info("checking nhs_number %r in %r", nhs_number, eligibility_service, extra={"nhs_number": nhs_number})

query_params = _get_or_default_query_params()
Expand Down
Loading