Skip to content

[ELI-686] - Adding custom subsegments for xray#598

Merged
TOEL2 merged 4 commits intomainfrom
feature/ELI-686-adding-subsegments
Mar 9, 2026
Merged

[ELI-686] - Adding custom subsegments for xray#598
TOEL2 merged 4 commits intomainfrom
feature/ELI-686-adding-subsegments

Conversation

@TOEL2
Copy link
Copy Markdown
Contributor

@TOEL2 TOEL2 commented Mar 9, 2026

Description

Adds in some wrappers to tell xray to track and organise bits of the code so that we can see it clearly in the dash and query it through the python sdk using subsegment names.

Focuses on external calls that we do as they are the bottleneck

well help us optimise our code by providing data about performance

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Comment thread src/eligibility_signposting_api/repos/campaign_repo.py
@eddalmond1
Copy link
Copy Markdown
Collaborator

No objection, would be good to have the sub segments or whatever in a diagram on the ticket / Confluence to illustrate what we expect to see

@TOEL2 TOEL2 merged commit c2ca492 into main Mar 9, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants