Skip to content

[ELI-686] - removing decorator as does not work with generators #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TOEL2 merged 2 commits into from
Mar 9, 2026
Merged

[ELI-686] - removing decorator as does not work with generators #600

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ff69e7
[ELI-686] - removing decorator as does not work with generators
TOEL2 Mar 9, 2026
d859479
Merge branch 'main' into feature/ELI-686-adding-subsegments
TOEL2 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/eligibility_signposting_api/repos/campaign_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ def __init__(
self.s3_client = s3_client
self.bucket_name = bucket_name

@xray_recorder.capture("CampaignRepo.get_campaign_configs") # pyright: ignore[reportCallIssue]
def get_campaign_configs(self) -> Generator[CampaignConfig]:
with xray_recorder.in_subsegment("CampaignRepo.get_campaign_configs:list_objects"):
campaign_objects = self.s3_client.list_objects(Bucket=self.bucket_name)
with xray_recorder.in_subsegment("CampaignRepo.get_campaign_configs:get_objects"):
for campaign_object in campaign_objects["Contents"]:
response = self.s3_client.get_object(Bucket=self.bucket_name, Key=f"{campaign_object['Key']}")
body = response["Body"].read()
yield Rules.model_validate(json.loads(body)).campaign_config
with xray_recorder.in_subsegment("CampaignRepo.get_campaign_configs"):
with xray_recorder.in_subsegment("list_objects"):
campaign_objects = self.s3_client.list_objects(Bucket=self.bucket_name)
with xray_recorder.in_subsegment("get_objects"):
for campaign_object in campaign_objects["Contents"]:
response = self.s3_client.get_object(Bucket=self.bucket_name, Key=f"{campaign_object['Key']}")
body = response["Body"].read()
yield Rules.model_validate(json.loads(body)).campaign_config
Loading