Skip to content

updated github actions policy #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oneeb-nhs merged 2 commits into from
Mar 30, 2026
+39 −5
Merged

updated github actions policy #621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a6e02
updated github actions policy
oneeb-nhs Mar 30, 2026
f2d9abf
replaced explicit cloudtrail action list to reduce policy size
oneeb-nhs Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 36 additions & 5 deletions infrastructure/stacks/iams-developer-roles/github_actions_policies.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ resource "aws_iam_policy" "s3_management" {
"arn:aws:s3:::*eligibility-signposting-api-${var.environment}-dq-metrics/*",
"arn:aws:s3:::*eligibility-signposting-api-${var.environment}-dq-metrics-access-logs",
"arn:aws:s3:::*eligibility-signposting-api-${var.environment}-dq-metrics-access-logs/*",
"arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-logs",
"arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-logs/*",
"arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-logs-access-logs",
"arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-logs-access-logs/*",
]
}
]
Expand All @@ -259,6 +263,12 @@ resource "aws_iam_policy" "api_infrastructure" {
Effect = "Allow",
Action = [
"logs:Describe*",
"cloudtrail:DescribeTrails",
"cloudtrail:GetEventSelectors",
"cloudtrail:GetTrail",
"cloudtrail:GetTrailStatus",
"cloudtrail:ListTags",
"cloudtrail:ListTrails",
"ssm:DescribeParameters",
"ec2:Describe*",
"ec2:DescribeVpcs",
Expand Down Expand Up @@ -315,7 +325,10 @@ resource "aws_iam_policy" "api_infrastructure" {
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:/aws/wafv2/*",
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:aws-wafv2-logs-*",
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:aws-waf-logs-*",
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:/aws/stepfunctions/*"
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:/aws/stepfunctions/*",
# CloudTrail log group
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:*elid-aws-cloudtrail-logs",
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:*elid-aws-cloudtrail-logs:*"
]
},
{
Expand Down Expand Up @@ -348,7 +361,9 @@ resource "aws_iam_policy" "api_infrastructure" {
"arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/*firehose*role*",
"arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/splunk-firehose-assume-role*",
# CSOC CloudWatch Logs subscription role
"arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/*-CWLogsSubscriptionRole"
"arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/*-CWLogsSubscriptionRole",
# CloudTrail to CloudWatch Logs role
"arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/cloudtrail-cloudwatch-role"
],
Condition = {
StringEquals = {
Expand All @@ -358,7 +373,8 @@ resource "aws_iam_policy" "api_infrastructure" {
"vpc-flow-logs.amazonaws.com",
"events.amazonaws.com",
"firehose.amazonaws.com",
"logs.amazonaws.com"
"logs.amazonaws.com",
"cloudtrail.amazonaws.com"
]
}
}
Expand All @@ -374,6 +390,16 @@ resource "aws_iam_policy" "api_infrastructure" {
"logs:PutMetricFilter",
"logs:TagResource",

# CloudTrail
"cloudtrail:AddTags",
"cloudtrail:CreateTrail",
"cloudtrail:DeleteTrail",
"cloudtrail:PutEventSelectors",
"cloudtrail:RemoveTags",
"cloudtrail:StartLogging",
"cloudtrail:StopLogging",
"cloudtrail:UpdateTrail",

# EC2 permissions
"ec2:CreateTags",
"ec2:DeleteTags",
Expand Down Expand Up @@ -460,6 +486,8 @@ resource "aws_iam_policy" "api_infrastructure" {
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:/aws/apigateway/*",
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:/aws/kinesisfirehose/eligibility-signposting-api-${var.environment}-audit/*",
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:NHSDAudit_trail_log_group*",
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:*elid-aws-cloudtrail-logs",
"arn:aws:logs:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:log-group:*elid-aws-cloudtrail-logs:*",
"arn:aws:ssm:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:parameter/${var.environment}/*",
"arn:aws:ssm:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:parameter/splunk/*",
"arn:aws:ssm:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:parameter/ptl/*",
Expand All @@ -469,7 +497,8 @@ resource "aws_iam_policy" "api_infrastructure" {
"arn:aws:wafv2:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:regional/webacl/*",
"arn:aws:wafv2:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:regional/managedruleset/*",
"arn:aws:states:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:stateMachine:*",
"arn:aws:events:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:rule/*"
"arn:aws:events:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:rule/*",
"arn:aws:cloudtrail:${var.default_aws_region}:${data.aws_caller_identity.current.account_id}:trail/${var.project_name}-${var.environment}-*"
]
},
]
Expand Down Expand Up @@ -605,7 +634,9 @@ resource "aws_iam_policy" "iam_management" {
# Eventbridge invoke step functions role
"arn:aws:iam::*:role/eventbridge_invoke_sfn_role",
"arn:aws:iam::*:role/secret_rotation_lambda_role",
"arn:aws:iam::*:role/secret_rotation_workflow_role"
"arn:aws:iam::*:role/secret_rotation_workflow_role",
# CloudTrail to CloudWatch Logs role
"arn:aws:iam::*:role/cloudtrail-cloudwatch-role"
]
}
]
Expand Down
16 changes: 16 additions & 0 deletions infrastructure/stacks/iams-developer-roles/iams_permissions_boundary.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,22 @@ data "aws_iam_policy_document" "permissions_boundary" {
"cloudwatch:GetDashboard",
"cloudwatch:GetMetricWidgetImage",

# CloudTrail - trail management
"cloudtrail:AddTags",
Copy link
Copy Markdown
Collaborator

@eddalmond1 eddalmond1 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloudtrail:* can be used here, as it's a permissions boundary (so doesn't grant wide-reaching permissions). We use :* as the policy is reaching the point of being too big!

Copy link
Copy Markdown
Contributor Author

@oneeb-nhs oneeb-nhs Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated as suggested

"cloudtrail:CreateTrail",
"cloudtrail:DeleteTrail",
"cloudtrail:DescribeTrails",
"cloudtrail:GetEventSelectors",
"cloudtrail:GetTrail",
"cloudtrail:GetTrailStatus",
"cloudtrail:ListTags",
"cloudtrail:ListTrails",
"cloudtrail:PutEventSelectors",
"cloudtrail:RemoveTags",
"cloudtrail:StartLogging",
"cloudtrail:StopLogging",
"cloudtrail:UpdateTrail",

# DynamoDB - table management
"dynamodb:Describe*",
"dynamodb:ListTables",
Expand Down
Loading