[ELI-702] consolidating s3 perms, security perms and streaming perms#634
Merged
[ELI-702] consolidating s3 perms, security perms and streaming perms#634
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates GitHub Actions IAM policies in the iams-developer-roles Terraform stack, reducing the number of separate policy resources by merging related permissions (S3 + Terraform state, KMS + code signing, Firehose + Kinesis).
Changes:
- Merged Terraform state S3 permissions into the existing
s3_managementpolicy and removed the dedicated Terraform state policy/attachment. - Combined KMS key management and Lambda code-signing permissions into a new
security_managementpolicy and updated attachments accordingly. - Consolidated Firehose and Kinesis permissions into a single
stream_managementpolicy and updated attachments accordingly.
eddalmond1
approved these changes
Apr 10, 2026
eddalmond1
reviewed
Apr 10, 2026
|
|
||
| tags = merge(local.tags, { Name = "github-actions-kms-creation" }) | ||
| tags = merge(local.tags, { Name = "security-management" }) | ||
| } |
Collaborator
There was a problem hiding this comment.
We've skipped this intentionally as the scopes of the actions are at account level, not resource level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.