Skip to content

Chore: [AEA-6527] - fix permissions so can publish packages #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tstephen-nhs merged 8 commits into from
Apr 7, 2026
Merged

Chore: [AEA-6527] - fix permissions so can publish packages #127

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b5cbc37
chore: actionlint error by replacing alias step entries with explicit…
tstephen-nhs Apr 7, 2026
51c4899
Merge branch 'main' into aea-6257-fix-package-perms
tstephen-nhs Apr 7, 2026
e05f226
revert: aliased workflow steps
tstephen-nhs Apr 7, 2026
315038b
Merge branch 'main' into aea-6257-fix-package-perms
tstephen-nhs Apr 7, 2026
a4d7996
chore: trigger build
tstephen-nhs Apr 7, 2026
67028e9
chore: pr needs to grant packages write too
tstephen-nhs Apr 7, 2026
8dfa5ed
chore: update zizmor for the last commit
tstephen-nhs Apr 7, 2026
36729f1
chore: package permissions for tag-release
tstephen-nhs Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 53 additions & 10 deletions .github/workflows/quality-checks-devcontainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,15 @@ jobs:
outputs:
docker_images: ${{ steps.normalized_docker_images.outputs.images }}
steps:
- *init_tool_versions
- *checkout
- name: copy .tool-versions
run: |
cp /home/vscode/.tool-versions "$HOME/.tool-versions"

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
ref: ${{ env.BRANCH_NAME }}
Comment thread
tstephen-nhs marked this conversation as resolved.
Outdated
fetch-depth: 0
- name: Determine docker images to scan
id: normalized_docker_images
env:
Expand Down Expand Up @@ -272,10 +279,28 @@ jobs:
matrix:
docker_image: ${{ fromJson(needs.get_docker_images_to_scan.outputs.docker_images) }}
steps:
- *init_tool_versions
- *checkout
- *setup_npmrc
- *cache_npm
- name: copy .tool-versions
run: |
cp /home/vscode/.tool-versions "$HOME/.tool-versions"

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
ref: ${{ env.BRANCH_NAME }}
Comment thread
tstephen-nhs marked this conversation as resolved.
Outdated
fetch-depth: 0

- name: Setting up .npmrc
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
echo "//npm.pkg.github.com/:_authToken=${NODE_AUTH_TOKEN}" >> ~/.npmrc
echo "@nhsdigital:registry=https://npm.pkg.github.com" >> ~/.npmrc

- name: Cache npm dependencies
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7
with:
path: ./node_modules
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}

- name: make install
run: |
Expand Down Expand Up @@ -307,10 +332,28 @@ jobs:
run:
shell: bash
steps:
- *init_tool_versions
- *checkout
- *setup_npmrc
- *cache_npm
- name: copy .tool-versions
run: |
cp /home/vscode/.tool-versions "$HOME/.tool-versions"

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
ref: ${{ env.BRANCH_NAME }}
Comment thread
tstephen-nhs marked this conversation as resolved.
Outdated
fetch-depth: 0

- name: Setting up .npmrc
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
echo "//npm.pkg.github.com/:_authToken=${NODE_AUTH_TOKEN}" >> ~/.npmrc
echo "@nhsdigital:registry=https://npm.pkg.github.com" >> ~/.npmrc

- name: Cache npm dependencies
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7
with:
path: ./node_modules
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}

- name: Check for SAM templates
id: check_sam_templates
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tag-release-devcontainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ jobs:
permissions:
id-token: "write"
contents: "write"
packages: "write"
Comment thread
tstephen-nhs marked this conversation as resolved.
runs-on: ubuntu-22.04
container:
image: ${{ inputs.pinned_image }}
Expand Down