Skip to content

Fix: [AEA-0000] - Always run valid trivy scans even if a previous scan failed, so that all vulnerabilities are identified at once. Shorten feedback cycle for vulnerabilities across multiple scans. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connoravo-nhs merged 3 commits into from
Mar 5, 2026
+4 −4
Merged

Fix: [AEA-0000] - Always run valid trivy scans even if a previous scan failed, so that all vulnerabilities are identified at once. Shorten feedback cycle for vulnerabilities across multiple scans. #78

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
417b5c5
Always run valid trivy scans even if a previous scan failed, so that …
connoravo-nhs Mar 5, 2026
0e15f69
Apply suggestion from @tstephen-nhs
connoravo-nhs Mar 5, 2026
c7930db
Switch to always
connoravo-nhs Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/quality-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ jobs:
path: sbom.cdx.json

- name: Check python vulnerabilities
if: ${{ steps.check_languages.outputs.uses_poetry == 'true' }}
if: ${{ steps.check_languages.outputs.uses_poetry == 'true' && failure()}}
Comment thread
connoravo-nhs marked this conversation as resolved.
Outdated
uses: aquasecurity/trivy-action@97e0b3872f55f89b95b2f65b3dbab56962816478
with:
scan-type: "fs"
Expand All @@ -276,7 +276,7 @@ jobs:
exit-code: "1"
trivy-config: trivy.yaml
- name: Check node vulnerabilities
if: ${{ steps.check_languages.outputs.uses_node == 'true' }}
if: ${{ steps.check_languages.outputs.uses_node == 'true' && failure() }}
uses: aquasecurity/trivy-action@97e0b3872f55f89b95b2f65b3dbab56962816478
with:
scan-type: "fs"
Expand All @@ -289,7 +289,7 @@ jobs:
exit-code: "1"
trivy-config: trivy.yaml
- name: Check go vulnerabilities
if: ${{ steps.check_languages.outputs.uses_go == 'true' }}
if: ${{ steps.check_languages.outputs.uses_go == 'true' && failure()}}
uses: aquasecurity/trivy-action@97e0b3872f55f89b95b2f65b3dbab56962816478
with:
scan-type: "fs"
Expand All @@ -301,7 +301,7 @@ jobs:
output: "dependency_results_go.txt"
exit-code: "1"
- name: Check java vulnerabilities
if: ${{ steps.check_languages.outputs.uses_java == 'true' }}
if: ${{ steps.check_languages.outputs.uses_java == 'true' && failure()}}
uses: aquasecurity/trivy-action@97e0b3872f55f89b95b2f65b3dbab56962816478
with:
scan-type: "fs"
Expand Down