Skip to content

Fix: [AEA-0000] - Fix minor bugs in notifications#1583

Merged
wildjames merged 6 commits intomainfrom
aea-0000-notifications-bugfixes
Apr 29, 2025
Merged

Fix: [AEA-0000] - Fix minor bugs in notifications#1583
wildjames merged 6 commits intomainfrom
aea-0000-notifications-bugfixes

Conversation

@wildjames
Copy link
Copy Markdown
Contributor

Summary

  • Routine Change

Details

Some issues have been found in QA with the current notifications code

  • The initial logging message when the producer lambda checks if anything is to be added to SQS was confusing. Updated it
  • The status checking logic was case-sensitive (it should be case insensitive)
  • The lambda name was confusing

This is a small PR to address these problems.

@wildjames wildjames enabled auto-merge (squash) April 29, 2025 14:11
@github-actions
Copy link
Copy Markdown
Contributor

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

AEA-0000

@wildjames wildjames changed the title fix: [AEA-0000] - Fix minor bugs in notifications Fix: [AEA-0000] - Fix minor bugs in notifications Apr 29, 2025
@wildjames wildjames closed this Apr 29, 2025
auto-merge was automatically disabled April 29, 2025 14:11

Pull request was closed

@wildjames wildjames reopened this Apr 29, 2025
anthony-nhs
anthony-nhs previously approved these changes Apr 29, 2025
@sonarqubecloud
Copy link
Copy Markdown

@wildjames wildjames merged commit 8de7174 into main Apr 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants