Chore: [AEA-6055] - new index for post dated#2910
Merged
tstephen-nhs merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6055 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new DynamoDB GSI that includes the post-dated attribute in its projection, and updates the GSUL query code to use the new index to work around CloudFormation’s inability to update existing GSI projections.
Changes:
- Add a new GSI
PharmacyODSCodePrescriptionIDIndexIncPostDated(keeping the old index unchanged). - Update GSUL DynamoDB query code to use the new index.
- Update GSUL unit test expectations to match the new index name.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/gsul/tests/testRunDynamoDBQueries.test.ts | Updates test expectation for the new GSI name. |
| packages/gsul/src/dynamoDBclient.ts | Switches the QueryCommandInput to use the new GSI. |
| SAMtemplates/tables/main.yaml | Adds the new GSI with the post-dated attribute projected. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
wildjames
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Fix: AEA-6055 - debugging issues with post-dated updates passed on a PR branch becasue we create a new table there but failed on merge to main:
So this PR creates a new secondary index to be used temporarily until we can disable post-dated updates functionality. This is why the original index is left in place.