Chore: [AEA-6428] - Filter for notifications by application ID rather than name

[wildjames]

Summary

• Routine Change

Details

We need to update the code to filter notification suppliers based on product ID rather than by application name (which may change without us knowing).

However, there needs to be a switchover period. I will implement the logic for the new way in parallel to the old, and have an environment variable USE_PRODUCT_ID_FOR_NOTIFICATIONS_FILTERING that toggles from one to the other. The enabled product IDs will be a new parameter also.

The order of operations will be:

• release this version out to prod, defaulting to still use the application name to filter on
• Populate the product IDs for the currently enabled suppliers
• Flip the environment variable to move to using product ID
  • Verify that it's working as expected
• Create a new PR which removes the (now unused) product name filtering code, the EnabledSystemsParameter, and the environment variable USE_PRODUCT_ID_FOR_NOTIFICATIONS_FILTERING.
• Release that to prod
• Verify we're still good

[github-actions]

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-6428

[Copilot]

Pull request overview

Updates the PSU pipeline to support identifying notification suppliers by application/product ID (via nhsd-application-id) instead of relying on application name, and propagates the new identifier through persisted data and filtering.

Changes:

• Add ApplicationID to PSUDataItem and populate it from the nhsd-application-id request header.
• Switch notification enablement filtering from ApplicationName to ApplicationID.
• Update API specification and unit tests to reflect the new header/field.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/updatePrescriptionStatus/src/updatePrescriptionStatus.ts	Reads nhsd-application-id header and persists it on generated data items.
packages/updatePrescriptionStatus/src/validation/notificationSiteAndSystemFilters.ts	Changes supplier filtering to use ApplicationID instead of ApplicationName.
packages/common/commonTypes/src/index.ts	Adds ApplicationID to the shared PSUDataItem type.
packages/specification/eps-prescription-status-update-api.yaml	Enables product ID checking and declares nhsd-application-id as a target attribute/header.
packages/updatePrescriptionStatus/tests/utils/testUtils.ts	Adds ApplicationID to mock data item helper.
packages/updatePrescriptionStatus/tests/testUpdatePrescriptionStatus.test.ts	Updates buildDataItems calls for the new signature.
packages/updatePrescriptionStatus/tests/testSqsClient.test.ts	Updates mock data to include ApplicationID where needed.
packages/updatePrescriptionStatus/tests/testDatabaseClient.test.ts	Updates persisted item fixtures to include ApplicationID.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[wildjames]

Uses app ID and successfully passes through an enabled supplier (me)

[tstephen-nhs]

gratuitious whitespace change?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud