Skip to content

Chore: [AEA-6424] - use new common workflows#2951

Merged
anthony-nhs merged 6 commits intomainfrom
new_qc
Apr 8, 2026
Merged

Chore: [AEA-6424] - use new common workflows#2951
anthony-nhs merged 6 commits intomainfrom
new_qc

Conversation

@anthony-nhs
Copy link
Copy Markdown
Contributor

Summary

  • Routine Change

Details

  • move to latest qc
  • remove all trivy files
  • add CODEOWNERS to restrict updates to workflows
  • use least permissions on all workflows
  • add --ignore-scripts true to npm install

Copilot AI review requested due to automatic review settings April 8, 2026 08:22
@anthony-nhs anthony-nhs changed the title Chore: [AEA-0000] - use new common workflows#4525 Chore: [AEA-6424] - use new common workflows#4525 Apr 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this repo to align with the latest eps-common-workflows and hardens workflow/repo guardrails (least-privilege permissions, ownership restrictions), while replacing Trivy ignore configuration with Grype/Zizmor configuration.

Changes:

  • Bump reusable workflow references to the latest NHSDigital/eps-common-workflows and add explicit least-privilege permissions blocks across workflows.
  • Add Grype/Zizmor configuration and wire a Grype scan into pre-commit; ignore generated SBOM output.
  • Add CODEOWNERS protection for workflow updates and remove legacy Trivy ignore + deprecated composite actions.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
zizmor.yml Adds Zizmor rule ignores for known findings in workflows.
.trivyignore.yaml Removes Trivy ignore list (risk: Trivy config still present elsewhere).
.pre-commit-config.yaml Adds a local pre-commit hook to run a Grype scan.
.grype.yaml Adds Grype ignore configuration for a specific GHSA.
.gitignore Ignores .sbom/ output directory.
.github/workflows/run_release_code_and_api.yml Adds workflow-level permissions lockdown and various hardening tweaks (checkout credential persistence, env usage).
.github/workflows/run_regression_tests.yml Adds workflow-level permissions lockdown and checkout hardening.
.github/workflows/run_package_code_and_api.yml Adds workflow-level permissions lockdown and checkout hardening.
.github/workflows/release.yml Updates common workflow pins and adds explicit job permissions.
.github/workflows/pull_request.yml Updates common workflow pins and adds explicit job permissions.
.github/workflows/delete_old_cloudformation_stacks.yml Adds workflow-level permissions lockdown and checkout hardening.
.github/workflows/ci.yml Updates common workflow pins and adds explicit job permissions.
.github/CODEOWNERS Restricts approvals for workflow changes to @NHSDigital/eps-admins.
.github/actions/update_confluence_jira/action.yml Removes unused composite action.
.github/actions/mark_jira_released/action.yml Removes unused composite action.
.devcontainer/devcontainer.json Bumps devcontainer image version.

Comment thread .github/workflows/run_release_code_and_api.yml
Comment thread .github/workflows/run_release_code_and_api.yml
Comment thread .github/workflows/run_regression_tests.yml
Comment thread .pre-commit-config.yaml
Comment thread .pre-commit-config.yaml
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/pull_request.yml
@anthony-nhs anthony-nhs changed the title Chore: [AEA-6424] - use new common workflows#4525 Chore: [AEA-6424] - use new common workflows Apr 8, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2026

Comment thread .github/CODEOWNERS
@anthony-nhs anthony-nhs merged commit af6f748 into main Apr 8, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants