Skip to content

Chore: [AEA-0000] - bump dev container version to 1.4.8 #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Apr 17, 2026
Merged

Chore: [AEA-0000] - bump dev container version to 1.4.8 #2972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"args": {
"DOCKER_GID": "${env:DOCKER_GID:}",
"IMAGE_NAME": "node_24_python_3_12",
"IMAGE_VERSION": "v1.4.4",
"IMAGE_VERSION": "v1.4.8",
"USER_UID": "${localEnv:USER_ID:}",
"USER_GID": "${localEnv:GROUP_ID:}"
},
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
verify_published_from_main_image: true

quality_checks:
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@c8f899f30a6a726859b0277faa73cd9ff7f4de20
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now pins quality-checks-devcontainer.yml to a different eps-common-workflows commit than the other reusable workflows in the same file (get-repo-config.yml, tag-release-devcontainer.yml). Mixing versions from the same upstream repo can introduce subtle incompatibilities (inputs/outputs/permissions) and makes upgrades harder to reason about. Consider bumping all NHSDigital/eps-common-workflows/.github/workflows/* references in this workflow to the same commit SHA (or centralising the SHA via a single variable) so they stay in sync.

Suggested change
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@c8f899f30a6a726859b0277faa73cd9ff7f4de20

Copilot uses AI. Check for mistakes.
needs: [get_config_values]
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
verify_published_from_main_image: false

quality_checks:
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@c8f899f30a6a726859b0277faa73cd9ff7f4de20
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now pins quality-checks-devcontainer.yml to a different eps-common-workflows commit than the other reusable workflows in the same file (get-repo-config.yml, tag-release-devcontainer.yml, etc.). Keeping all reusable workflow references from the same upstream repo on a single commit SHA helps avoid compatibility issues and simplifies future bumps. Consider updating the remaining eps-common-workflows references here to the same SHA (or centralising the SHA) to keep them aligned.

Suggested change
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@c8f899f30a6a726859b0277faa73cd9ff7f4de20

Copilot uses AI. Check for mistakes.
needs: [get_config_values]
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
with:
verify_published_from_main_image: true
quality_checks:
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@c8f899f30a6a726859b0277faa73cd9ff7f4de20
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now pins quality-checks-devcontainer.yml to a different eps-common-workflows commit than the other reusable workflows in the same file (get-repo-config.yml, tag-release-devcontainer.yml). Using multiple versions of the same upstream reusable-workflow repo in one workflow increases the risk of mismatched inputs/outputs and complicates debugging. Consider bumping the other eps-common-workflows references in this file to the same commit SHA (or centralising the SHA) so they stay consistent.

Suggested change
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@c8f899f30a6a726859b0277faa73cd9ff7f4de20

Copilot uses AI. Check for mistakes.
needs: [get_config_values]
permissions:
contents: read
Expand Down
6 changes: 3 additions & 3 deletions zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ rules:
unpinned-images:
# these workflows use unpinned images because they are using a full image passed in that contains the tag
ignore:
- run_release_code_and_api.yml:146:7
- run_regression_tests.yml:26:7
- run_package_code_and_api.yml:16:7
- run_release_code_and_api.yml:146:18
- run_regression_tests.yml:26:18
- run_package_code_and_api.yml:16:18
secrets-outside-env:
# these are ignored because they are using known secrets
ignore:
Expand Down