Skip to content

fix: revert aliases which creates incompatibilities with visualizer-helper#1242

Merged
stropitek merged 1 commit into
masterfrom
revert-twig-aliases
May 7, 2026
Merged

fix: revert aliases which creates incompatibilities with visualizer-helper#1242
stropitek merged 1 commit into
masterfrom
revert-twig-aliases

Conversation

@stropitek
Copy link
Copy Markdown
Collaborator

@stropitek stropitek commented May 7, 2026

Requirejs does not like it when the same dependency is loaded directly and via a configured path. We should always use the alias or always use the configured path.

I chose to remove the configured path in order to improve the compatibility with https://github.com/cheminfo-js/visualizer-helper

Here is a view reproducing the issue:

reproduction.json

There can be 2 possible symptoms depending on the order in which dependencies are loaded:

  • Require in init script never resolves => "ok" log not printed
  • Require in twig module never resolves => Twig module never appears

@stropitek stropitek merged commit 7106693 into master May 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant