Fixed missing detector arming in standard collection#320
Open
MSkinner (mskinner5278) wants to merge 1 commit into
Open
Fixed missing detector arming in standard collection#320MSkinner (mskinner5278) wants to merge 1 commit into
MSkinner (mskinner5278) wants to merge 1 commit into
Conversation
MSkinner (mskinner5278)
requested review from
Jun Aishima (JunAishima) and
RobertSchaffer1
Jun Aishima (JunAishima)
requested changes
Jul 28, 2023
Collaborator
Jun Aishima (JunAishima)
left a comment
Jun Aishima (JunAishima)
left a comment
There was a problem hiding this comment.
fix how to use flyer.detector_arm()
| 'data_path':data_path} | ||
| start_time = time.time() | ||
| #flyer.detector_arm(**required_parameters) | ||
| flyer.detector_arm(**required_parameters) |
Collaborator
There was a problem hiding this comment.
this is not correct. look at the flyer.detector_arm() code and see what its return value is and how your code needs to be changed.
Collaborator
Author
There was a problem hiding this comment.
We were getting NoneType back instead of the status object, so I have moved the creation of the status object to the collection to allow operations to continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.