Qtsignals refactor#321
Open
Shekar V (vshekar) wants to merge 7 commits into
Open
Conversation
Previously, any Epics PV that triggers a change in the QT UI would do the following: - Define EPICS PV - Define QtSignal - EPICS callback that triggers the QT signal - QT Signal then runs a callback that does some work in the frontend In practically every case, the EPICS callback simply takes the PV value and passes it to the qt signal. This leads to repeating code and very little variation (not DRY) `EpicsQObject` attempts to address that. There are escape hatches in case there is a need for custom epics callbacks
Shekar V (vshekar)
force-pushed
the
qtsignals-refactor
branch
from
d8511a2 to
e1fb579
Compare
Collaborator
Jun Aishima (JunAishima)
left a comment
Jun Aishima (JunAishima)
left a comment
There was a problem hiding this comment.
Removing boilerplate and using f-strings instead of raw addition are very welcome, but it is unclear whether the custom_pv kwarg is necessary with the current LSDC code and this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any Epics PV that triggers a change in the QT UI would do the following:
In practically every case, the EPICS callback simply takes the PV value and passes it to the qt signal. This leads to repeating code and very little variation (not DRY)
EpicsQObjectattempts to address that. There are escape hatches in case there is a need for custom epics callbacks