Draft
Conversation
This reverts commit 4cf8f8b.
…sks-filter-ui-clean
🩺 React Doctor |
TkymHrt
reviewed
May 7, 2026
Member
TkymHrt
left a comment
TkymHrt
left a comment
There was a problem hiding this comment.
修正ありがとー
概ね良さそうでした！
細かいとこだけコメントしました。
| itemIds: [], | ||
| }); | ||
| const [selectedTaskId, setSelectedTaskId] = useState<string | null>(null); | ||
| const [selectedTask, setSelectedTask] = useState<UserTask | null>(null); |
Member
There was a problem hiding this comment.
変更前のようにIDのみをStateに持って、実データはPropsから～の方が良さそうかな
router.refresh() かけてもStateの状態は更新されないから、更新漏れがでそう
Comment on lines
-61
to
-64
| const selectedTask = useMemo( | ||
| () => tasks.find((task) => task.taskId === selectedTaskId) ?? null, | ||
| [selectedTaskId, tasks], | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
タスク一覧 / User画面のフィルターUIを修正しました。
場所フィルターでは中間階層を候補に出さず、末端の場所だけを選択できるようにしています。
変更点
関連Issue
スクリーンショット（UI変更がある場合）
動作確認手順
/admin/tasksにアクセスする/tasksにアクセスするレビューしてほしいポイント
セルフチェックリスト