Draft
Conversation
Remove dependency on rmm::mr::device_memory_resource base class. Resources now satisfy the cuda::mr::resource concept directly. - Replace shared_ptr<device_memory_resource> with value types and cuda::mr::any_resource<cuda::mr::device_accessible> for type-erased storage - Replace set_current_device_resource(ptr) with set_current_device_resource_ref - Replace set_per_device_resource(id, ptr) with set_per_device_resource_ref - Remove make_owning_wrapper usage - Remove dynamic_cast on memory resources (no common base class) - Remove owning_wrapper.hpp and device_memory_resource.hpp includes - Add missing thrust/iterator/transform_output_iterator.h include (no longer transitively included via CCCL)
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
46 tasks
# Conflicts: # cpp/src/utilities/cuda_helpers.cuh
bdice
force-pushed
the
rmm-cccl-migration
branch
4 times, most recently
from
a624829 to
8fe66e5
Compare
bdice
added
breaking
bdice
force-pushed
the
rmm-cccl-migration
branch
5 times, most recently
from
3c4bbbe to
717e877
Compare
bdice
force-pushed
the
rmm-cccl-migration
branch
from
717e877 to
b42797f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rmm::mr::device_memory_resourcebase class; resources now satisfy thecuda::mr::resourceconcept directlyshared_ptr<device_memory_resource>with value types andcuda::mr::any_resource<cuda::mr::device_accessible>for type-erased storageset_current_device_resource(ptr)/set_per_device_resource(id, ptr)withset_current_device_resource_ref/set_per_device_resource_refmake_owning_wrapperusage anddynamic_caston memory resources (no common base class)thrust/iterator/transform_output_iterator.hinclude (no longer transitively included via CCCL)Details
8 files changed, 24 insertions, 41 deletions. C++ build passes (all 62 targets). Cython build failures are pre-existing (missing
pylibraftdev headers, unrelated to this change).