Generalize tokenizer, enable future parametrization of architectures#38
Merged
Generalize tokenizer, enable future parametrization of architectures#38
Conversation
akaIDIOT
commented
Apr 30, 2026
ranieri
reviewed
May 8, 2026
| if hasattr(self, 'model'): | ||
| self.model.tokenizer = tokenizer | ||
|
|
||
| def preprocess(self, inputs, prompt=None, architecture='arm64', **kwargs): |
Member
There was a problem hiding this comment.
This handles the actual forwarding. The test now passes locally.
NB: this *FAILS*, someone in the call stack ignores it for our case…
ranieri
force-pushed
the
feature/generalize-tokenizer
branch
from
5a14296 to
67de0d1
Compare
ranieri
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.