Open
Conversation
Member
|
We're still missing immediate value bucketing/normalization. That can go in a later pull request. |
ranieri
approved these changes
May 7, 2026
|
|
||
|
|
||
| def test_parse_single_operand(): | ||
| assert riscv.parse_instruction('j x032') == ('j', ('x032',)) |
Member
There was a problem hiding this comment.
is "x032" a typo?
I would expect 0x32 (address) or x31 (register, but it only goes up to x31, there is no x32).
| import re | ||
| from collections.abc import Iterator | ||
|
|
||
| from networkx import DiGraph |
Member
There was a problem hiding this comment.
This dependency is getting removed soon. We are standardizing on dict/list.
| assert tokens.count('OBFUSCATED') == 2 | ||
|
|
||
|
|
||
| # todo: adjust to risc-v; requires a riscv subfolder under asmtransformers/models |
Member
There was a problem hiding this comment.
This is a tokenizer thing, not a preprocessor thing, I'm OK with dropping this from here. It will be lifted from the ARM64 impl when we start generalizing.
| "torch", | ||
| "transformers", | ||
| "tzlocal>=5.3.1", | ||
| "pandas>=3.0.2", |
Member
There was a problem hiding this comment.
Do we need this? Who's using it?
Also, it's not in the PDM lock change. If we really want to make sure everyone gets it, we need to re-lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.