Cleanup read csv#29
Merged
PimMeulensteen merged 4 commits intomainfrom Mar 19, 2026
Merged
Conversation
PimMeulensteen
force-pushed
the
cleanup-read-csv
branch
from
28d20c5 to
f15fd1e
Compare
PimMeulensteen
force-pushed
the
cleanup-read-csv
branch
2 times, most recently
from
1f368ed to
eb75246
Compare
wowtor
approved these changes
Mar 17, 2026
| return all_features[:, 0] | ||
|
|
||
|
|
||
| def transform_marktype_accf(original_score): |
Contributor
There was a problem hiding this comment.
deze kan er denk ik ook uit?
Contributor
Author
There was a problem hiding this comment.
op zich vind ik het niet zo erg om deze er in te houden, voor het geval we toch ooit accf willen gebruiken.
| @@ -20,43 +16,6 @@ class TestTrainSplit(StrEnum): | |||
| SPLIT_COLUMNS = ["split1", "split2", "split3"] | |||
Contributor
There was a problem hiding this comment.
ik denk dat deze SPLIT_COLUMNS ook wel weg kan, want hij zit al in de yaml? Hij wordt nu alleen nog gebruikt in de PredefinedCrossValidation om het aantal splits te herleiden, maar dat kan ook uit de shape van de splits attribute, en dan is het gegarandeerd in sync met de data.
PimMeulensteen
force-pushed
the
cleanup-read-csv
branch
from
eb75246 to
e4e5458
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.