fix marktype specific for impression or striation#212
Merged
Conversation
laurensWe
approved these changes
Mar 30, 2026
SimoneAriens
requested changes
Mar 30, 2026
Collaborator
SimoneAriens
left a comment
SimoneAriens
left a comment
There was a problem hiding this comment.
please change MarkStriation | MarkImpression to MarkType wherever possible
SimoneAriens
approved these changes
Mar 31, 2026
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
packages/scratch-core/src/conversion/export/mark.pyLines 29-37 29
30
31 def _parse_mark_type(value: Any) -> MarkType:
32 if isinstance(value, (MarkImpressionType, MarkStriationType)):
! 33 return value
34 s = str(value)
35 for enum_type in (MarkImpressionType, MarkStriationType):
36 if s in enum_type:
37 return enum_type(s) |
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits up
MarkTypeinto specificMarkStriationandMarkImpressionso the endpoint schema gives the correct marktypes to choose from. (when #177 ) is merged a dropdown list is also available to choose from. which helps that the user can only select the correct types.( also in code alot of
if marktype==is used what now is not needed anymore.This is a Draft because this is only a first draft that splits up the marks. alot of code need to be changed for embracing this split.