Skip to content

Enforce LF line endings to fix yamllint CRLF failures on Windows #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbampton merged 4 commits into from
May 2, 2026
+19 −0
Merged

Enforce LF line endings to fix yamllint CRLF failures on Windows #469

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c68a856
Initial plan
Copilot May 2, 2026
fc255a9
Fix yamllint failure on Windows by enforcing LF line endings
Copilot May 2, 2026
c24d58f
Address Gemini review: expand binary file types and add types: [text]…
Copilot May 2, 2026
7eb73e2
Update .pre-commit-config.yaml
jbampton May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Enforce LF line endings for all text files to prevent CRLF issues on Windows
* text=auto eol=lf

# Explicitly enforce LF for YAML files (prevents yamllint failures on Windows)
*.yaml text eol=lf
*.yml text eol=lf

# Binary files
*.png binary
*.jpg binary
*.jpeg binary
*.gif binary
*.ico binary
Comment thread
jbampton marked this conversation as resolved.
*.webp binary
*.avif binary
*.pdf binary
*.woff binary
*.woff2 binary
2 changes: 2 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ repos:
- id: mixed-line-ending
name: run mixed-line-ending
description: replaces or checks mixed line ending
args: [--fix=lf]
Comment thread
jbampton marked this conversation as resolved.
types: [text]
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The types: [text] property is redundant because the mixed-line-ending hook already includes types: [text] in its default configuration (as defined in the pre-commit-hooks manifest). Removing it keeps the configuration cleaner without changing the behavior.

        args: [--fix=lf]

Comment thread
jbampton marked this conversation as resolved.
Outdated

- repo: https://github.com/biomejs/pre-commit
rev: "v2.4.8"
Expand Down
Loading