Changed filenames to include first domain or inbound port#5515
Open
joewesch wants to merge 1 commit intoNginxProxyManager:developfrom
Open
Changed filenames to include first domain or inbound port#5515joewesch wants to merge 1 commit intoNginxProxyManager:developfrom
joewesch wants to merge 1 commit intoNginxProxyManager:developfrom
Conversation
|
Docker Image for build 1 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #746
This PR is an upgraded replacement for #2606.
This PR changes all config filenames to be
id.first_domainfor proxy_host, redirection_host or dead_host andid.incoming_portfor stream. Each type will fall back to justidif there are no domains or if the type is undefined. All log files will also be renamed accordingly automatically.This will also happen if the user either adds a domain to the host that sorts alphabetically first or if they remove the first domain. These changes will not take effect immediately, which seems to be in-line with the rest of the upgrades in this project. They will instead update the next time each host is saved.