Skip to content

Adds column sorting to Nginx tables#5520

Open
D0LBA3B wants to merge 1 commit intoNginxProxyManager:developfrom
D0LBA3B:feature/sortable-tables
Open

Adds column sorting to Nginx tables#5520
D0LBA3B wants to merge 1 commit intoNginxProxyManager:developfrom
D0LBA3B:feature/sortable-tables

Conversation

@D0LBA3B
Copy link
Copy Markdown

@D0LBA3B D0LBA3B commented May 5, 2026

Issue #3158

Adds sorting on the columns of the Nginx tables (Proxy Hosts, Redirection Hosts, Dead Hosts and Streams)
The project already uses TanStack React Table so it was mostly a matter of enabling getSortedRowModel and adding a small sort indicator in the table header

Sortable columns

  • Proxy Hosts => Source, Destination, Status
  • Redirection Hosts => Source, HTTP Code, Scheme, Destination, Status
  • Dead Hosts => Source, Status
  • Streams => Incoming Port, Destination, Status

@nginxproxymanagerci
Copy link
Copy Markdown

CI Error:

/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
certbot-node: Pulling from nginxproxymanager/nginx-full
37bb98e96b2a: Pulling fs layer
97444fd4ebcf: Pulling fs layer
ff86ea2e5edc: Pulling fs layer
df22f5fdf20c: Pulling fs layer
1ba795db7415: Pulling fs layer
dda10b01a93a: Pulling fs layer
7e44045be568: Pulling fs layer
6759d0dafd10: Pulling fs layer
0aad857f0c0e: Pulling fs layer
c15c85224221: Pulling fs layer
ae6e38bdb6ba: Pulling fs layer
cc7c25955ddd: Pulling fs layer
943e7992bc37: Pulling fs layer
0eb2f9672480: Pulling fs layer
8cf55e8ec16a: Pulling fs layer
42c13e3cc1b9: Pulling fs layer
d0c76c00114e: Pulling fs layer
6a845ad9e02e: Pulling fs layer
d0cb57570715: Pulling fs layer
ec48b7658206: Pulling fs layer
5ef8e7382c85: Pulling fs layer
df22f5fdf20c: Download complete
dda10b01a93a: Download complete
6759d0dafd10: Download complete
37bb98e96b2a: Download complete
97444fd4ebcf: Download complete
7e44045be568: Download complete
0aad857f0c0e: Download complete
8cf55e8ec16a: Download complete
943e7992bc37: Download complete
42c13e3cc1b9: Download complete
ae6e38bdb6ba: Download complete
d0c76c00114e: Download complete
5ef8e7382c85: Download complete
cc7c25955ddd: Download complete
d0cb57570715: Download complete
ff86ea2e5edc: Download complete
6a845ad9e02e: Download complete
ec48b7658206: Download complete
1ba795db7415: Download complete
c15c85224221: Download complete
a1dbfabefc72: Download complete
0eb2f9672480: Download complete
df22f5fdf20c: Pull complete
ff86ea2e5edc: Pull complete
dda10b01a93a: Pull complete
7e44045be568: Pull complete
1ba795db7415: Pull complete
6759d0dafd10: Pull complete
0aad857f0c0e: Pull complete
c15c85224221: Pull complete
97444fd4ebcf: Pull complete
ae6e38bdb6ba: Pull complete
d0c76c00114e: Pull complete
d0cb57570715: Pull complete
5ef8e7382c85: Pull complete
6a845ad9e02e: Pull complete
ec48b7658206: Pull complete
943e7992bc37: Pull complete
cc7c25955ddd: Pull complete
37bb98e96b2a: Pull complete
8cf55e8ec16a: Pull complete
42c13e3cc1b9: Pull complete
0eb2f9672480: Pull complete
Digest: sha256:398efb1bf34e80518e535c6baf42467c653eaceacd512e2865a764e139fb5be6
Status: Downloaded newer image for nginxproxymanager/nginx-full:certbot-node
docker.io/nginxproxymanager/nginx-full:certbot-node
�[1;34m❯ �[1;36mBuilding Frontend ...�[0m
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @uiw/react-textarea-code-editor@3.1.1" has unmet peer dependency "@babel/runtime@>=7.10.0".
[4/4] Building fresh packages...
Done in 30.11s.
yarn run v1.22.22
$ biome lint
Checked 226 files in 88ms. No fixes applied.
Done in 0.15s.
yarn run v1.22.22
$ formatjs compile-folder src/locale/src src/locale/lang
Done in 0.25s.
yarn run v1.22.22
$ /app/frontend/node_modules/.bin/vitest run --no-color

 RUN  v4.0.18 /app/frontend

 ❯ src/locale/Utils.test.tsx (0 test)

⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/locale/Utils.test.tsx [ src/locale/Utils.test.tsx ]
Error: Failed to parse JSON file, invalid JSON syntax found at position -1
  Plugin: vite:json
  File: /app/frontend/src/locale/lang/de.json
 ❯ TransformPluginContext._formatLog node_modules/vite/dist/node/chunks/config.js:28999:43
 ❯ TransformPluginContext.error node_modules/vite/dist/node/chunks/config.js:28996:14
 ❯ TransformPluginContext.handler node_modules/vite/dist/node/chunks/config.js:8890:11
 ❯ EnvironmentPluginContainer.transform node_modules/vite/dist/node/chunks/config.js:28797:51
 ❯ loadAndTransform node_modules/vite/dist/node/chunks/config.js:22670:26

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯


 Test Files  1 failed (1)
      Tests  no tests
   Start at  19:22:03
   Duration  418ms (transform 61ms, setup 56ms, import 0ms, tests 0ms, environment 161ms)

$ formatjs compile-folder src/locale/src src/locale/lang

$ ./src/locale/scripts/locale-sort.sh
bg.json is already sorted
cs.json is already sorted
de.json is already sorted
en.json is already sorted
es.json is already sorted
et.json is already sorted
fr.json is already sorted
ga.json is already sorted
hu.json is already sorted
id.json is already sorted
it.json is already sorted
ja.json is already sorted
ko.json is already sorted
nl.json is already sorted
no.json is already sorted
pl.json is already sorted
pt.json is already sorted
ru.json is already sorted
sk.json is already sorted
tr.json is already sorted
vi.json is already sorted
zh.json is already sorted

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant