Skip to content

language/docker: init#1431

Merged
snoweuph merged 2 commits into
NotAShelf:mainfrom
snoweuph:feat/docker
May 14, 2026
Merged

language/docker: init#1431
snoweuph merged 2 commits into
NotAShelf:mainfrom
snoweuph:feat/docker

Conversation

@snoweuph
Copy link
Copy Markdown
Collaborator

@snoweuph snoweuph commented Feb 27, 2026 •
edited
Loading

Adds support for docker, docker compose and also docker in terraform.

most if it was already created in #1104.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

snoweuph
snoweuph commented Feb 27, 2026
View reviewed changes
Comment thread modules/plugins/languages/docker.nix Outdated
snoweuph
snoweuph commented Feb 27, 2026
View reviewed changes
Comment thread modules/plugins/languages/docker.nix
github-actions Bot pushed a commit that referenced this pull request Feb 27, 2026
@actions-user
Deploy PR #1431 preview
5b94e93
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 27, 2026 •
edited
Loading

🚀 Live preview deployed from ab45944

View it here:

Debug Information

Triggered by: snoweuph

HEAD at: feat/docker

Reruns: 2945

@snoweuph snoweuph force-pushed the feat/docker branch 2 times, most recently from 3b5abee to c6cdb87 Compare February 27, 2026 20:19
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Mar 19, 2026

rebased for my sanity

github-actions Bot pushed a commit that referenced this pull request Mar 21, 2026
@actions-user
Deploy PR #1431 preview
eb9280d
github-actions Bot pushed a commit that referenced this pull request Mar 21, 2026
@actions-user
Deploy PR #1431 preview
2ae2fc8
@snoweuph snoweuph added the TBD More discussion and research is in order label Mar 28, 2026
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Mar 29, 2026 •
edited
Loading

I'm already using this in my nvf based config:

But as this requires a ftdetect to work correctly, this wont get merged any time soon, because we don't include those in nvf, but there is work on an new API for exactly this in: #1365.
till then I will rebase this from time to time...

So for anybody that wants docker support in their config, feel free to steal my config, as long as you're human.

@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Apr 7, 2026

rebased

@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented Apr 19, 2026

rebased

github-actions Bot pushed a commit that referenced this pull request Apr 19, 2026
@actions-user
Deploy PR #1431 preview
5583fc1
@snoweuph snoweuph force-pushed the feat/docker branch 3 times, most recently from d804d8d to 3daaa3e Compare April 19, 2026 00:53
snoweuph
snoweuph commented Apr 19, 2026
View reviewed changes
Comment thread modules/plugins/languages/docker.nix
@snoweuph snoweuph marked this pull request as ready for review April 19, 2026 00:56
@snoweuph snoweuph requested a review from NotAShelf as a code owner April 19, 2026 00:56
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented May 1, 2026

rebased

@snoweuph snoweuph linked an issue May 3, 2026 that may be closed by this pull request
Docker Support #1558
Closed
1 task
github-actions Bot pushed a commit that referenced this pull request May 3, 2026
@actions-user
Deploy PR #1431 preview
29d5f1c
github-actions Bot pushed a commit that referenced this pull request May 3, 2026
@actions-user
Deploy PR #1431 preview
76d4444
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented May 3, 2026

rebased

@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented May 5, 2026

rebased

github-actions Bot pushed a commit that referenced this pull request May 5, 2026
@actions-user
Deploy PR #1431 preview
2ccdf6c
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented May 6, 2026

rebased

github-actions Bot pushed a commit that referenced this pull request May 6, 2026
@actions-user
Deploy PR #1431 preview
62b89a5
@snoweuph snoweuph enabled auto-merge May 9, 2026 21:14
github-actions Bot pushed a commit that referenced this pull request May 10, 2026
@actions-user
Deploy PR #1431 preview
8f97829
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented May 10, 2026

rebased

@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented May 12, 2026

rebased

github-actions Bot pushed a commit that referenced this pull request May 12, 2026
@actions-user
Deploy PR #1431 preview
f90259c
@snoweuph
Copy link
Copy Markdown
Collaborator Author

snoweuph commented May 13, 2026

rebased

github-actions Bot pushed a commit that referenced this pull request May 13, 2026
@actions-user
Deploy PR #1431 preview
8cdff15
@snoweuph snoweuph merged commit 6b8e926 into NotAShelf:main May 14, 2026
14 checks passed
@snoweuph snoweuph deleted the feat/docker branch May 14, 2026 17:15
sand4rt
sand4rt reviewed May 14, 2026
View reviewed changes
Comment thread modules/plugins/languages/docker.nix
@snoweuph snoweuph mentioned this pull request May 14, 2026
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NotAShelf NotAShelf NotAShelf approved these changes

@horriblename horriblename Awaiting requested review from horriblename horriblename is a code owner

@Soliprem Soliprem Awaiting requested review from Soliprem Soliprem is a code owner

+1 more reviewer

@sand4rt sand4rt sand4rt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

TBD More discussion and research is in order topic: documentation topic: modules topic: plugins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docker Support

3 participants

@snoweuph @sand4rt @NotAShelf